Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: Source/devtools/front_end/SplitView.js

Issue 71633003: DevTools: added "overlayContents" mode, where DevTools content is placed around and underneath inse… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 10 *
(...skipping 290 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 this._resizerElement.style.bottom = sizeValue; 301 this._resizerElement.style.bottom = sizeValue;
302 this._resizerElement.style.marginBottom = -this._resizerElementS ize / 2 + "px"; 302 this._resizerElement.style.marginBottom = -this._resizerElementS ize / 2 + "px";
303 } else { 303 } else {
304 this._resizerElement.style.top = sizeValue; 304 this._resizerElement.style.top = sizeValue;
305 this._resizerElement.style.marginTop = -this._resizerElementSize / 2 + "px"; 305 this._resizerElement.style.marginTop = -this._resizerElementSize / 2 + "px";
306 } 306 }
307 } 307 }
308 308
309 this._sidebarSize = size; 309 this._sidebarSize = size;
310 310
311 this.onLayoutUpdated();
312
311 // No need to recalculate this._sidebarSize and this._totalSize again. 313 // No need to recalculate this._sidebarSize and this._totalSize again.
312 this._muteOnResize = true; 314 this._muteOnResize = true;
313 this.doResize(); 315 this.doResize();
314 delete this._muteOnResize; 316 delete this._muteOnResize;
315 }, 317 },
316 318
317 /** 319 /**
318 * @param {number=} minWidth 320 * @param {number=} minWidth
319 * @param {number=} minHeight 321 * @param {number=} minHeight
320 */ 322 */
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 this._updateLayout(); 385 this._updateLayout();
384 }, 386 },
385 387
386 onResize: function() 388 onResize: function()
387 { 389 {
388 if (this._muteOnResize) 390 if (this._muteOnResize)
389 return; 391 return;
390 this._updateLayout(); 392 this._updateLayout();
391 }, 393 },
392 394
395 onLayoutUpdated: function()
pfeldman 2013/11/18 15:07:42 There is an event in SidebarView for that, all you
dgozman 2013/11/21 16:38:51 Looks like that event is only fired on the whole e
396 {
397 // Override this method to do something when layout changes.
398 },
399
393 /** 400 /**
394 * @param {Event} event 401 * @param {Event} event
395 * @return {boolean} 402 * @return {boolean}
396 */ 403 */
397 _startResizerDragging: function(event) 404 _startResizerDragging: function(event)
398 { 405 {
399 if (!this._resizable) 406 if (!this._resizable)
400 return false; 407 return false;
401 408
402 this._saveSidebarSizeRecursively(); 409 this._saveSidebarSizeRecursively();
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
497 else 504 else
498 this._savedSidebarHeight = size; 505 this._savedSidebarHeight = size;
499 506
500 var sizeSetting = this._sizeSetting(); 507 var sizeSetting = this._sizeSetting();
501 if (sizeSetting) 508 if (sizeSetting)
502 sizeSetting.set(size); 509 sizeSetting.set(size);
503 }, 510 },
504 511
505 __proto__: WebInspector.View.prototype 512 __proto__: WebInspector.View.prototype
506 } 513 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698