content/browser/web_contents/web_contents_impl.cc - Issue 71633002: Convert SignedCertificateClass to be ref_counted, and add an SCTStore in which to store them. Add S…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 71633002: Convert SignedCertificateClass to be ref_counted, and add an SCTStore in which to store them. Add S… Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: few lint fixes Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index fc194cd5c91c52d3fe45169a72ad0712f63b1ad0..5eba64b32d7f1ce894ff0ed05e7aa95ed593dfd0 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -2134,10 +2134,10 @@ void WebContentsImpl::OnDidLoadResourceFromMemoryCache(

net::CertStatus cert_status = 0;

int security_bits = -1;

int connection_status = 0;

- int signed_certificate_timestamp_id = 0;

+ content::SCTIdStatusList signed_certificate_timestamp_ids;

DeserializeSecurityInfo(security_info, &cert_id, &cert_status,

&security_bits, &connection_status,

- &signed_certificate_timestamp_id);

+ &signed_certificate_timestamp_ids);

// XXX(rsleevi): Track the SCT here

LoadFromMemoryCacheDetails details(

url, GetRenderProcessHost()->GetID(), cert_id, cert_status, http_method,

« no previous file with comments | « content/browser/ssl/ssl_manager.cc ('k') | content/common/ssl_status_serialization.h » ('j') | no next file with comments »