Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: content/common/ssl_status_serialization.cc

Issue 71633002: Convert SignedCertificateClass to be ref_counted, and add an SCTStore in which to store them. Add S… Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: few lint fixes Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/common/ssl_status_serialization.h ('k') | content/content_browser.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/common/ssl_status_serialization.h" 5 #include "content/common/ssl_status_serialization.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/pickle.h" 8 #include "base/pickle.h"
9 9
10 namespace content { 10 namespace content {
11 11
12 std::string SerializeSecurityInfo(int cert_id, 12 std::string SerializeSecurityInfo(int cert_id,
13 net::CertStatus cert_status, 13 net::CertStatus cert_status,
14 int security_bits, 14 int security_bits,
15 int ssl_connection_status, 15 int ssl_connection_status,
16 int signed_certificate_timestamp_id) { 16 const SCTIdStatusList&
17 signed_certificate_timestamp_ids) {
17 Pickle pickle; 18 Pickle pickle;
18 pickle.WriteInt(cert_id); 19 pickle.WriteInt(cert_id);
19 pickle.WriteUInt32(cert_status); 20 pickle.WriteUInt32(cert_status);
20 pickle.WriteInt(security_bits); 21 pickle.WriteInt(security_bits);
21 pickle.WriteInt(ssl_connection_status); 22 pickle.WriteInt(ssl_connection_status);
22 pickle.WriteInt(signed_certificate_timestamp_id); 23 pickle.WriteInt(signed_certificate_timestamp_ids.size());
24 for (SCTIdStatusList::const_iterator iter =
25 signed_certificate_timestamp_ids.begin();
26 iter != signed_certificate_timestamp_ids.end(); ++iter) {
27 pickle.WriteInt(iter->first); // sct_id
28 pickle.WriteUInt16(iter->second); // verification status
29 }
23 return std::string(static_cast<const char*>(pickle.data()), pickle.size()); 30 return std::string(static_cast<const char*>(pickle.data()), pickle.size());
24 } 31 }
25 32
26 bool DeserializeSecurityInfo(const std::string& state, 33 bool DeserializeSecurityInfo(const std::string& state,
27 int* cert_id, 34 int* cert_id,
28 net::CertStatus* cert_status, 35 net::CertStatus* cert_status,
29 int* security_bits, 36 int* security_bits,
30 int* ssl_connection_status, 37 int* ssl_connection_status,
31 int* signed_certificate_timestamp_id) { 38 SCTIdStatusList*
39 signed_certificate_timestamp_ids) {
32 DCHECK(cert_id && cert_status && security_bits && ssl_connection_status); 40 DCHECK(cert_id && cert_status && security_bits && ssl_connection_status);
33 if (state.empty()) { 41 if (state.empty()) {
34 // No SSL used. 42 // No SSL used.
35 *cert_id = 0; 43 *cert_id = 0;
36 // The following are not applicable and are set to the default values. 44 // The following are not applicable and are set to the default values.
37 *cert_status = 0; 45 *cert_status = 0;
38 *security_bits = -1; 46 *security_bits = -1;
39 *ssl_connection_status = 0; 47 *ssl_connection_status = 0;
40 *signed_certificate_timestamp_id = 0; 48 signed_certificate_timestamp_ids->clear();
41 return false; 49 return false;
42 } 50 }
43 51
44 Pickle pickle(state.data(), static_cast<int>(state.size())); 52 Pickle pickle(state.data(), static_cast<int>(state.size()));
45 PickleIterator iter(pickle); 53 PickleIterator iter(pickle);
46 return pickle.ReadInt(&iter, cert_id) && 54 bool pickle_read_ok = pickle.ReadInt(&iter, cert_id) &&
47 pickle.ReadUInt32(&iter, cert_status) && 55 pickle.ReadUInt32(&iter, cert_status) &&
48 pickle.ReadInt(&iter, security_bits) && 56 pickle.ReadInt(&iter, security_bits) &&
49 pickle.ReadInt(&iter, ssl_connection_status) && 57 pickle.ReadInt(&iter, ssl_connection_status);
50 pickle.ReadInt(&iter, signed_certificate_timestamp_id); 58 if (pickle_read_ok) {
59 int num_scts_to_read;
60 pickle_read_ok = pickle.ReadInt(&iter, &num_scts_to_read);
61 int id;
62 net::SignedCertificateTimestampVerificationStatus status;
63 for (; num_scts_to_read > 0 && pickle_read_ok; --num_scts_to_read) {
64 pickle_read_ok &= pickle.ReadInt(&iter, &id) &&
65 pickle.ReadUInt16(&iter, &status);
66 if (pickle_read_ok)
67 signed_certificate_timestamp_ids->push_back(
68 std::make_pair(id, status));
69 }
70 }
71
72 return pickle_read_ok;
51 } 73 }
52 74
53 } // namespace content 75 } // namespace content
OLDNEW
« no previous file with comments | « content/common/ssl_status_serialization.h ('k') | content/content_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698