Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 716253002: Make system tray icons not show up as blurry on KDE (Closed)

Created:
6 years, 1 month ago by pkotwicz
Modified:
6 years, 1 month ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@system_tray_proper
Project:
chromium
Visibility:
Public.

Description

Make system tray icons not show up as blurry on KDE KDE uses 24x24 system tray icons. If a smaller icon is provided, KDE stretches the icon which makes it look blurry. This CL makes the system tray icons used by Chrome 24x24 by padding the icons with transparent pixels. BUG=382487 TEST=Manual Committed: https://crrev.com/9bf1973b0fe56de26cf85009457c9ed8f5e757d7 Cr-Commit-Position: refs/heads/master@{#304086}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -124 lines) Patch
M chrome/browser/ui/libgtk2ui/app_indicator_icon.h View 3 chunks +28 lines, -2 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/app_indicator_icon.cc View 1 5 chunks +130 lines, -122 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
pkotwicz
Elliot, PTAL https://codereview.chromium.org/716253002/diff/60001/chrome/browser/ui/libgtk2ui/app_indicator_icon.cc File chrome/browser/ui/libgtk2ui/app_indicator_icon.cc (right): https://codereview.chromium.org/716253002/diff/60001/chrome/browser/ui/libgtk2ui/app_indicator_icon.cc#newcode271 chrome/browser/ui/libgtk2ui/app_indicator_icon.cc:271: "chrome_app_indicator2_%s", base::MD5DigestToBase16(digest).c_str()); This is "chrome_app_indicator2" on purpose. ...
6 years, 1 month ago (2014-11-13 05:02:39 UTC) #5
Elliot Glaysher
lgtm
6 years, 1 month ago (2014-11-13 18:54:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716253002/80001
6 years, 1 month ago (2014-11-13 20:52:34 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:80001)
6 years, 1 month ago (2014-11-13 21:32:55 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 21:33:42 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9bf1973b0fe56de26cf85009457c9ed8f5e757d7
Cr-Commit-Position: refs/heads/master@{#304086}

Powered by Google App Engine
This is Rietveld 408576698