Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 716243004: Fixing title capitalization and inconsistency for nacl cds2014 codelab. (Closed)

Created:
6 years, 1 month ago by bradn
Modified:
6 years, 1 month ago
Reviewers:
jpmedley, binji
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixing title capitalization and inconsistency for nacl cds2014 codelab. R=binji@chromium.org, jmedley@chromium.org BUG=None Committed: https://chromium.googlesource.com/chromium/src/+/689344e312566593f65e1a42236be688ae422b20

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M native_client_sdk/doc_generated/cds2014/index.html View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/cds2014/python.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/doc_generated/sitemap.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/doc/cds2014/index.rst View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/doc/cds2014/python.rst View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
bradn
6 years, 1 month ago (2014-11-17 22:12:58 UTC) #1
jpmedley
LGTM
6 years, 1 month ago (2014-11-17 22:43:23 UTC) #2
binji
lgtm
6 years, 1 month ago (2014-11-17 22:48:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716243004/1
6 years, 1 month ago (2014-11-17 22:50:52 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/689344e312566593f65e1a42236be688ae422b20 Cr-Commit-Position: refs/heads/master@{#304518}
6 years, 1 month ago (2014-11-17 23:34:33 UTC) #6
bradn
6 years, 1 month ago (2014-11-17 23:34:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
689344e312566593f65e1a42236be688ae422b20 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698