Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Side by Side Diff: Source/modules/push_messaging/PushEvent.cpp

Issue 716203003: The "push" event should inherit from ExtendableEvent. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove PushEvent from global ctors Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/modules/push_messaging/PushEvent.h ('k') | Source/modules/push_messaging/PushEvent.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/push_messaging/PushEvent.h" 6 #include "modules/push_messaging/PushEvent.h"
7 7
8 namespace blink { 8 namespace blink {
9 9
10 PushEventInit::PushEventInit() 10 PushEventInit::PushEventInit()
11 { 11 {
12 } 12 }
13 13
14 PushEvent::PushEvent() 14 PushEvent::PushEvent()
15 { 15 {
16 } 16 }
17 17
18 PushEvent::PushEvent(const AtomicString& type, const String& data) 18 PushEvent::PushEvent(const AtomicString& type, const String& data, WaitUntilObse rver* observer)
19 : Event(type, /*canBubble=*/false, /*cancelable=*/false) 19 : ExtendableEvent(type, ExtendableEventInit(), observer)
20 , m_data(data) 20 , m_data(data)
21 { 21 {
22 } 22 }
23 23
24 PushEvent::PushEvent(const AtomicString& type, const PushEventInit& initializer) 24 PushEvent::PushEvent(const AtomicString& type, const PushEventInit& initializer)
25 : Event(type, initializer) 25 : ExtendableEvent(type, initializer)
26 , m_data(initializer.data) 26 , m_data(initializer.data)
27 { 27 {
28 } 28 }
29 29
30 PushEvent::~PushEvent() 30 PushEvent::~PushEvent()
31 { 31 {
32 } 32 }
33 33
34 const AtomicString& PushEvent::interfaceName() const 34 const AtomicString& PushEvent::interfaceName() const
35 { 35 {
36 return EventNames::PushEvent; 36 return EventNames::PushEvent;
37 } 37 }
38 38
39 } // namespace blink 39 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/push_messaging/PushEvent.h ('k') | Source/modules/push_messaging/PushEvent.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698