Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: runtime/vm/regexp.h

Issue 716163003: Use one offsets table per generated irregexp matching function. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/regexp.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/regexp.h
diff --git a/runtime/vm/regexp.h b/runtime/vm/regexp.h
index 2675aaaf5a51ffe9ebd0fb29d4510ae1095abcc9..4b8d19c0eb12df0178d5c2844beb2a28bf228186 100644
--- a/runtime/vm/regexp.h
+++ b/runtime/vm/regexp.h
@@ -1372,26 +1372,21 @@ class RegExpEngine: public AllStatic {
public:
struct CompilationResult {
explicit CompilationResult(const char* error_message)
- : macro_assembler(NULL),
- graph_entry(NULL),
+ : graph_entry(NULL),
num_blocks(-1),
num_stack_locals(-1),
error_message(error_message) {}
- CompilationResult(IRRegExpMacroAssembler* macro_assembler,
- GraphEntryInstr* graph_entry,
+ CompilationResult(GraphEntryInstr* graph_entry,
intptr_t num_blocks,
intptr_t num_stack_locals)
- : macro_assembler(macro_assembler),
- graph_entry(graph_entry),
+ : graph_entry(graph_entry),
num_blocks(num_blocks),
num_stack_locals(num_stack_locals),
error_message(NULL) {}
- IRRegExpMacroAssembler* macro_assembler;
GraphEntryInstr* graph_entry;
const intptr_t num_blocks;
const intptr_t num_stack_locals;
-
const char* error_message;
};
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/regexp.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698