Use one offsets table per generated irregexp matching function.

runtime/vm/intermediate_language.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_INTERMEDIATE_LANGUAGE_H_
 #define VM_INTERMEDIATE_LANGUAGE_H_
 
 #include "vm/allocation.h"
 #include "vm/ast.h"
 #include "vm/growable_array.h"
@@ skipping 1314 matching lines @@
   }
 
   const GrowableArray<CatchBlockEntryInstr*>& catch_entries() const {
     return catch_entries_;
   }
 
   const GrowableArray<IndirectEntryInstr*>& indirect_entries() const {
     return indirect_entries_;
   }
 
+  void set_indirect_entry_offsets(GrowableObjectArray* offsets) {
+    ASSERT(offsets != NULL);
+    ASSERT(indirect_entry_offsets_ == NULL);
+    indirect_entry_offsets_ = offsets;
+  }
+
+  GrowableObjectArray* indirect_entry_offsets() const {
+    ASSERT(indirect_entry_offsets_ != NULL);
+    return indirect_entry_offsets_;
+  }
+
   virtual void PrintTo(BufferFormatter* f) const;
 
  private:
   virtual void ClearPredecessors() {}
   virtual void AddPredecessor(BlockEntryInstr* predecessor) { UNREACHABLE(); }
 
   const ParsedFunction* parsed_function_;
   TargetEntryInstr* normal_entry_;
   GrowableArray<CatchBlockEntryInstr*> catch_entries_;
   // Indirect targets are blocks reachable only through indirect gotos.
   GrowableArray<IndirectEntryInstr*> indirect_entries_;
+  GrowableObjectArray* indirect_entry_offsets_;
   GrowableArray<Definition*> initial_definitions_;
   const intptr_t osr_id_;
   intptr_t entry_count_;
   intptr_t spill_slot_count_;
   intptr_t fixed_slot_count_;  // For try-catch in optimized code.
 
   DISALLOW_COPY_AND_ASSIGN(GraphEntryInstr);
 };
 
 
@@ skipping 828 matching lines @@
 };
 
 
 // IndirectGotoInstr represents a dynamically computed jump. Only
 // IndirectEntryInstr targets are valid targets of an indirect goto. The
 // concrete target to jump to is given as a parameter to the indirect goto.
 //
 // In order to preserve split-edge form, an indirect goto does not itself point
 // to its targets. Instead, for each possible target, the successors_ field
 // will contain an ordinary goto instruction that jumps to the target.
-//
-// Byte offsets of all possible targets are stored in the offsets_ array. The
-// desired offset is looked up while the generated code is executing, and passed
-// to IndirectGoto as an input.
 class IndirectGotoInstr : public TemplateInstruction<1, NoThrow> {
  public:
-  IndirectGotoInstr(GrowableObjectArray* offsets,
-                    Value* offset_from_start)
-    : offsets_(*offsets) {
+  explicit IndirectGotoInstr(Value* offset_from_start) {
     SetInputAt(0, offset_from_start);
   }
 
   DECLARE_INSTRUCTION(IndirectGoto)
 
   virtual intptr_t ArgumentCount() const { return 0; }
 
   void AddSuccessor(TargetEntryInstr* successor) {
     ASSERT(successor->next()->IsGoto());
     ASSERT(successor->next()->AsGoto()->successor()->IsIndirectEntry());
     successors_.Add(successor);
   }
 
   virtual intptr_t SuccessorCount() const { return successors_.length(); }
   virtual TargetEntryInstr* SuccessorAt(intptr_t index) const {
     ASSERT(index < SuccessorCount());
     return successors_[index];
   }
 
   virtual bool CanDeoptimize() const { return false; }
   virtual bool CanBecomeDeoptimizationTarget() const { return false; }
 
   virtual EffectSet Effects() const { return EffectSet::None(); }
 
   virtual void PrintTo(BufferFormatter* f) const;
 
-  const GrowableObjectArray& offsets() const { return offsets_; }
-  void SetOffsetCount(Isolate* isolate, intptr_t count) {
-    if (offsets_.Capacity() < count) {
-      offsets_.Grow(count, Heap::kOld);
-    }
-    if (offsets_.Length() < count) {
-      offsets_.SetLength(count);
-    }
-  }
-  void SetOffsetAt(Isolate* isolate, intptr_t index, intptr_t offset) {
-    offsets_.SetAt(index, Smi::ZoneHandle(isolate, Smi::New(offset)));
-  }
-
  private:
   GrowableArray<TargetEntryInstr*> successors_;
-  GrowableObjectArray& offsets_;
 };
 
 
 class ComparisonInstr : public TemplateDefinition<2, NoThrow, Pure> {
  public:
   Value* left() const { return inputs_[0]; }
   Value* right() const { return inputs_[1]; }
 
   virtual intptr_t token_pos() const { return token_pos_; }
   Token::Kind kind() const { return kind_; }
@@ skipping 5727 matching lines @@
       Isolate* isolate, bool opt) const {                                     \
     UNIMPLEMENTED();                                                          \
     return NULL;                                                              \
   }                                                                           \
   void Name::EmitNativeCode(FlowGraphCompiler* compiler) { UNIMPLEMENTED(); }
 
 
 }  // namespace dart
 
 #endif  // VM_INTERMEDIATE_LANGUAGE_H_