Use one offsets table per generated irregexp matching function.

Use one offsets table per generated irregexp matching function.

BUG=

[zerny-google, 2014-11-12 11:11:22]

zerny@google.com changed reviewers:
+ fschneider@google.com, iposva@google.com, vegorov@google.com

[zerny-google, 2014-11-12 11:14:25]

This CL is based on top of the irregexp CL [1]. PTAL.

[1]: https://codereview.chromium.org/683433003/

[Florian Schneider, 2014-11-12 11:38:57]

lgtm

https://codereview.chromium.org/716163003/diff/1/runtime/vm/regexp_assembler.cc
File runtime/vm/regexp_assembler.cc (right):

https://codereview.chromium.org/716163003/diff/1/runtime/vm/regexp_assembler....
runtime/vm/regexp_assembler.cc:37: static const intptr_t kInvalidTryIndex = -1;
static const intptr_t kInvalidTryIndex = CatchClauseNode::kInvalidTryIndex

https://codereview.chromium.org/716163003/diff/1/runtime/vm/regexp_assembler....
runtime/vm/regexp_assembler.cc:38: static const intptr_t kNoTokenPos = 0;
Define in terms of Scanner::kNoSourcePos which is also 0.

https://codereview.chromium.org/716163003/diff/1/runtime/vm/regexp_assembler....
runtime/vm/regexp_assembler.cc:733: GrowableObjectArray& offsets =
*entry_block_->indirect_entry_offsets();
const GrowableObjectArray&

https://codereview.chromium.org/716163003/diff/1/runtime/vm/regexp_assembler....
runtime/vm/regexp_assembler.cc:790: if (!count) return;
Use count == 0 instead here.

[zerny-google, 2014-11-12 11:58:47]

Thanks for the review! Comments addressed in new patch set.

https://codereview.chromium.org/716163003/diff/1/runtime/vm/regexp_assembler.cc
File runtime/vm/regexp_assembler.cc (right):

https://codereview.chromium.org/716163003/diff/1/runtime/vm/regexp_assembler....
runtime/vm/regexp_assembler.cc:37: static const intptr_t kInvalidTryIndex = -1;
On 2014/11/12 11:38:56, Florian Schneider wrote:
> static const intptr_t kInvalidTryIndex = CatchClauseNode::kInvalidTryIndex

Done.

https://codereview.chromium.org/716163003/diff/1/runtime/vm/regexp_assembler....
runtime/vm/regexp_assembler.cc:38: static const intptr_t kNoTokenPos = 0;
On 2014/11/12 11:38:56, Florian Schneider wrote:
> Define in terms of Scanner::kNoSourcePos which is also 0.

Done.

https://codereview.chromium.org/716163003/diff/1/runtime/vm/regexp_assembler....
runtime/vm/regexp_assembler.cc:733: GrowableObjectArray& offsets =
*entry_block_->indirect_entry_offsets();
On 2014/11/12 11:38:56, Florian Schneider wrote:
> const GrowableObjectArray&

Done.

https://codereview.chromium.org/716163003/diff/1/runtime/vm/regexp_assembler....
runtime/vm/regexp_assembler.cc:790: if (!count) return;
On 2014/11/12 11:38:56, Florian Schneider wrote:
> Use count == 0 instead here.

Ok. But I rather removed the early return here.

[zerny-google, 2014-11-24 13:02:36]

Superseded by: https://codereview.chromium.org/722243002/