Switch release scripts to pure git.

Switch release scripts to pure git.

This removes all svn features from the release scripts.

This also fixes a bug in commit position retrieval.

BUG=chromium:410721
LOG=n
R=tandrii@chromium.org
TBR=tandrii@chromium.org
TEST=script_test.py

Committed: https://chromium.googlesource.com/v8/v8/+/90b6fc7f1cd0bc3bd5f099e6cdb83d01960da45d

[Michael Achenbach, 2014-11-12 10:53:35]

machenbach@chromium.org changed reviewers:
+ tandrii@chromium.org

[Michael Achenbach, 2014-11-12 10:56:12]

PTAL

https://codereview.chromium.org/716153002/diff/1/tools/push-to-trunk/common_i...
File tools/push-to-trunk/common_includes.py (left):

https://codereview.chromium.org/716153002/diff/1/tools/push-to-trunk/common_i...
tools/push-to-trunk/common_includes.py:452: self.step.Git("push
https://chromium.googlesource.com/v8/v8 %s" % ref)
This is no longer needed as all scripts have an extra workdir with a checkout
for pushing.

https://codereview.chromium.org/716153002/diff/1/tools/push-to-trunk/git_reci...
File tools/push-to-trunk/git_recipes.py (left):

https://codereview.chromium.org/716153002/diff/1/tools/push-to-trunk/git_reci...
tools/push-to-trunk/git_recipes.py:48: GIT_SVN_ID_RE =
re.compile(r'((?:\w+)://[^@]+)@(\d+)\s+(?:[a-zA-Z0-9\-]+)')
This is copied from bot_update. Added this bug:
https://code.google.com/p/chromium/issues/detail?id=432459

[tandrii(chromium), 2014-11-12 12:42:35]

LGTM

I second the bug filed against bot_update.

https://codereview.chromium.org/716153002/diff/1/tools/push-to-trunk/git_reci...
File tools/push-to-trunk/git_recipes.py (right):

https://codereview.chromium.org/716153002/diff/1/tools/push-to-trunk/git_reci...
tools/push-to-trunk/git_recipes.py:289: raise GitFailedException("Couldn't
determin commit position for %s" %
nit: determine

https://codereview.chromium.org/716153002/diff/1/tools/push-to-trunk/releases.py
File tools/push-to-trunk/releases.py (right):

https://codereview.chromium.org/716153002/diff/1/tools/push-to-trunk/releases...
tools/push-to-trunk/releases.py:233: return []
hm, is this actually being called? 
If so, then is returning [] a good thing? 
Otherwise, why not comment this function completely?

[Michael Achenbach, 2014-11-12 13:48:57]

Done. I added one more small feature to be able to push to candidates in patch
2. Does that look right?

https://codereview.chromium.org/716153002/diff/1/tools/push-to-trunk/releases.py
File tools/push-to-trunk/releases.py (right):

https://codereview.chromium.org/716153002/diff/1/tools/push-to-trunk/releases...
tools/push-to-trunk/releases.py:233: return []
On 2014/11/12 12:42:34, tandrii wrote:
> hm, is this actually being called? 
> If so, then is returning [] a good thing? 
> Otherwise, why not comment this function completely?

It's called and it should eventually be revived. Since a while, the automated
tagging on master is switched off. Therefore there is nothing to be found. If I
switch it on again, then [] would be wrong.

[tandrii(chromium), 2014-11-12 13:52:31]

still lgtm :)

https://codereview.chromium.org/716153002/diff/1/tools/push-to-trunk/releases.py
File tools/push-to-trunk/releases.py (right):

https://codereview.chromium.org/716153002/diff/1/tools/push-to-trunk/releases...
tools/push-to-trunk/releases.py:233: return []
On 2014/11/12 13:48:57, Michael Achenbach wrote:
> On 2014/11/12 12:42:34, tandrii wrote:
> > hm, is this actually being called? 
> > If so, then is returning [] a good thing? 
> > Otherwise, why not comment this function completely?
> 
> It's called and it should eventually be revived. Since a while, the automated
> tagging on master is switched off. Therefore there is nothing to be found. If
I
> switch it on again, then [] would be wrong.

Acknowledged.

https://codereview.chromium.org/716153002/diff/40001/tools/push-to-trunk/push...
File tools/push-to-trunk/push_to_trunk.py (right):

https://codereview.chromium.org/716153002/diff/40001/tools/push-to-trunk/push...
tools/push-to-trunk/push_to_trunk.py:58: 
lgtm

[Michael Achenbach, 2014-11-12 17:54:30]

Committed patchset #3 (id:40001) manually as
90b6fc7f1cd0bc3bd5f099e6cdb83d01960da45d (tree was closed).