Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 716143003: Make NotificationEvent constructable. (Closed)

Created:
6 years, 1 month ago by Peter Beverloo
Modified:
6 years, 1 month ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Make NotificationEvent constructable. This is possible now that Service Worker's ExtendableEvent has been made constructable. Specification: https://notifications.spec.whatwg.org/#service-worker-api BUG=432527 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185371

Patch Set 1 #

Patch Set 2 : add tests #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M LayoutTests/http/tests/notifications/serviceworker-notification-event.html View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M Source/modules/notifications/NotificationEvent.h View 3 chunks +6 lines, -1 line 0 comments Download
M Source/modules/notifications/NotificationEvent.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/modules/notifications/NotificationEvent.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Peter Beverloo
This is depending on the following two patches; I created it as a separate patch ...
6 years, 1 month ago (2014-11-12 17:42:01 UTC) #2
Michael van Ouwerkerk
lgtm
6 years, 1 month ago (2014-11-12 18:16:08 UTC) #3
Peter Beverloo
+mkwst for review This still depends on https://codereview.chromium.org/715013003/.
6 years, 1 month ago (2014-11-13 14:19:36 UTC) #5
Mike West
LGTM.
6 years, 1 month ago (2014-11-13 14:23:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716143003/40001
6 years, 1 month ago (2014-11-14 12:08:15 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 13:11:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 185371

Powered by Google App Engine
This is Rietveld 408576698