Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 716123003: Fix include mistakes (Closed)

Created:
6 years, 1 month ago by alexanderk
Modified:
6 years, 1 month ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Fix include mistakes 1) Missing <stdio.h> while using fopen, fclose, fseek etc 2) platform-linux.cc includes <sys/types.h> wtice BUG=v8:3691 Committed: https://chromium.googlesource.com/v8/v8/+/dd5afa6c15eac834a95fb82db30bf815df2012b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/base/platform/platform-linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/base/platform/platform-posix.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jochen (gone - plz use gerrit)
lgtm
6 years, 1 month ago (2014-11-12 15:03:16 UTC) #2
alexanderk
On 2014/11/12 15:03:16, jochen (slow) wrote: > lgtm Something strange with trybot results...
6 years, 1 month ago (2014-11-12 15:25:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716123003/1
6 years, 1 month ago (2014-11-18 13:21:19 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 13:47:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698