Added type annotations to galler/js/image_editor/image_encoder.js.

Added type annotations to galler/js/image_editor/image_encoder.js.

BUG=433728
TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/gallery/js/compiled_resources.gyp && ninja -C out/Default | grep "image_encoder.js"

Committed: https://crrev.com/2711eaf138dabfb689b74d6c1b074e5578787385
Cr-Commit-Position: refs/heads/master@{#304567}

[yawano, 2014-11-18 00:39:53]

yawano@chromium.org changed reviewers:
+ hirono@chromium.org

[yawano, 2014-11-18 00:39:54]

@hirono: PTAL. Thanks!

[hirono, 2014-11-18 01:43:55]

Thank you!

https://codereview.chromium.org/716093003/diff/1/ui/file_manager/gallery/js/i...
File ui/file_manager/gallery/js/image_editor/image_encoder.js (right):

https://codereview.chromium.org/716093003/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_encoder.js:156: * Convert string
to an array buffer.
nit: Converts

https://codereview.chromium.org/716093003/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_encoder.js:219: * Return a range
where the metadata is (or should be) located.
Please fix it with 'Returns'.

https://codereview.chromium.org/716093003/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_encoder.js:221: * @return
{!{from:number, to:number}} An object with from and to properties.
I think we don't need to add '!'. Record type (such as {from:number, to:number})
is non-nullable.

https://codereview.chromium.org/716093003/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_encoder.js:227: * Return
serialized metadata ready to write to an image file.
ditto.

https://codereview.chromium.org/716093003/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_encoder.js:229: * @return
{ArrayBuffer} Serialized metadata.
!ArrayBuffer ?

[yawano, 2014-11-18 04:26:53]

Thank you for the review! PTAL.

https://codereview.chromium.org/716093003/diff/1/ui/file_manager/gallery/js/i...
File ui/file_manager/gallery/js/image_editor/image_encoder.js (right):

https://codereview.chromium.org/716093003/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_encoder.js:156: * Convert string
to an array buffer.
On 2014/11/18 01:43:55, hirono wrote:
> nit: Converts

Done.

https://codereview.chromium.org/716093003/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_encoder.js:219: * Return a range
where the metadata is (or should be) located.
On 2014/11/18 01:43:55, hirono wrote:
> Please fix it with 'Returns'.

Done.

https://codereview.chromium.org/716093003/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_encoder.js:221: * @return
{!{from:number, to:number}} An object with from and to properties.
On 2014/11/18 01:43:55, hirono wrote:
> I think we don't need to add '!'. Record type (such as {from:number,
to:number})
> is non-nullable.

Done.

https://codereview.chromium.org/716093003/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_encoder.js:227: * Return
serialized metadata ready to write to an image file.
On 2014/11/18 01:43:55, hirono wrote:
> ditto.

Done.

https://codereview.chromium.org/716093003/diff/1/ui/file_manager/gallery/js/i...
ui/file_manager/gallery/js/image_editor/image_encoder.js:229: * @return
{ArrayBuffer} Serialized metadata.
On 2014/11/18 01:43:55, hirono wrote:
> !ArrayBuffer ?

Done.

[hirono, 2014-11-18 05:00:58]

lgtm with a nit. Thanks!

https://codereview.chromium.org/716093003/diff/20001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/image_editor/image_encoder.js (right):

https://codereview.chromium.org/716093003/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/image_editor/image_encoder.js:158: * @param {number}
from  Strt index.
Strt -> Start?

[yawano, 2014-11-18 05:05:22]

Thank you!

https://codereview.chromium.org/716093003/diff/20001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/image_editor/image_encoder.js (right):

https://codereview.chromium.org/716093003/diff/20001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/image_editor/image_encoder.js:158: * @param {number}
from  Strt index.
On 2014/11/18 05:00:58, hirono wrote:
> Strt -> Start?

Done.

[yawano, 2014-11-18 05:05:28]

The CQ bit was checked by yawano@chromium.org

[commit-bot: I haz the power, 2014-11-18 05:06:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/716093003/40001

[commit-bot: I haz the power, 2014-11-18 05:47:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-18 05:48:30]

Patchset 3 (id:??) landed as
https://crrev.com/2711eaf138dabfb689b74d6c1b074e5578787385
Cr-Commit-Position: refs/heads/master@{#304567}