Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Issue 716083003: [ServiceWorker] support OPTIONS request for ServiceWorker [2/3 chromium] (Closed)

Created:
6 years, 1 month ago by horo
Modified:
6 years, 1 month ago
Reviewers:
yhirano
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] support OPTIONS request for ServiceWorker [2/3 chromium] Currently we can't handle OPTIONS request in the ServiceWorker. This check is done in content/browser/service_worker/service_worker_request_handler.cc. But we should support OPTIONS request except for CORS preflight request. [1/3] blink: https://codereview.chromium.org/738033002/ Set SkipServiceWorker flag for CORS preflight request. [2/3] chromium: https://codereview.chromium.org/716083003/ Remove IsMethodSupportedForServiceWorker check in service_worker_request_handler.cc [3/3] blink: https://codereview.chromium.org/743653002/ Cleanup and add update LayoutTest. BUG=434660 Committed: https://crrev.com/1df059534ca200db1ef3189fd1e23fc7641c984f Cr-Commit-Position: refs/heads/master@{#305250}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M content/browser/service_worker/service_worker_request_handler.cc View 2 chunks +1 line, -10 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
horo
yhirano@ Could you please review this?
6 years, 1 month ago (2014-11-19 12:43:12 UTC) #2
yhirano
lgtm
6 years, 1 month ago (2014-11-21 03:38:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/716083003/1
6 years, 1 month ago (2014-11-21 17:54:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-21 18:46:14 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 18:47:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1df059534ca200db1ef3189fd1e23fc7641c984f
Cr-Commit-Position: refs/heads/master@{#305250}

Powered by Google App Engine
This is Rietveld 408576698