Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 716043002: Implement event sender service for testing (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
esprehn, eseidel
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Implement event sender service for testing This service lets us send Mojo events during testing. R=eseidel@chromium.org, esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3d683fc9242067fd00a006a5ce7f58bde4d3a63a

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -24 lines) Patch
A + sky/services/testing/BUILD.gn View 1 chunk +2 lines, -4 lines 0 comments Download
A + sky/services/testing/test_harness.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
M sky/tests/services/event-sender.sky View 1 chunk +23 lines, -6 lines 0 comments Download
A sky/tests/services/event-sender-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M sky/tools/tester/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sky/tools/tester/test_harness_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/tester/test_runner.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/tools/tester/tester.cc View 1 chunk +2 lines, -0 lines 3 comments Download
M sky/viewer/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M sky/viewer/internals.h View 1 chunk +1 line, -1 line 0 comments Download
D sky/viewer/services/test_harness.mojom View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
6 years, 1 month ago (2014-11-12 01:28:24 UTC) #1
eseidel
lgtm https://codereview.chromium.org/716043002/diff/1/sky/tools/tester/tester.cc File sky/tools/tester/tester.cc (right): https://codereview.chromium.org/716043002/diff/1/sky/tools/tester/tester.cc#newcode59 sky/tools/tester/tester.cc:59: if (test_runner_) Why the null check?
6 years, 1 month ago (2014-11-12 03:18:55 UTC) #3
abarth-chromium
https://codereview.chromium.org/716043002/diff/1/sky/tools/tester/tester.cc File sky/tools/tester/tester.cc (right): https://codereview.chromium.org/716043002/diff/1/sky/tools/tester/tester.cc#newcode59 sky/tools/tester/tester.cc:59: if (test_runner_) On 2014/11/12 at 03:18:54, eseidel wrote: > ...
6 years, 1 month ago (2014-11-12 03:19:56 UTC) #4
abarth-chromium
6 years, 1 month ago (2014-11-12 18:46:39 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
3d683fc9242067fd00a006a5ce7f58bde4d3a63a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698