Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: sky/engine/core/html/HTMLImageElement.cpp

Issue 715963003: Remove alt text from images. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: minor improvement Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/html/HTMLImageElement.h ('k') | sky/engine/core/rendering/RenderImage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/html/HTMLImageElement.cpp
diff --git a/sky/engine/core/html/HTMLImageElement.cpp b/sky/engine/core/html/HTMLImageElement.cpp
index 777b12207bbd25c8fd31c191e9635a12589de894..428c08c3e8c97e8263d580ba2a7c6c03d06e52f6 100644
--- a/sky/engine/core/html/HTMLImageElement.cpp
+++ b/sky/engine/core/html/HTMLImageElement.cpp
@@ -151,28 +151,13 @@ void HTMLImageElement::setBestFitURLAndDPRFromImageCandidate(const ImageCandidat
void HTMLImageElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
{
- if (name == HTMLNames::altAttr) {
- if (renderer() && renderer()->isImage())
- toRenderImage(renderer())->updateAltText();
- } else if (name == HTMLNames::srcAttr || name == HTMLNames::srcsetAttr || name == HTMLNames::sizesAttr) {
+ if (name == HTMLNames::srcAttr || name == HTMLNames::srcsetAttr || name == HTMLNames::sizesAttr) {
selectSourceURL(ImageLoader::UpdateIgnorePreviousError);
} else {
HTMLElement::parseAttribute(name, value);
}
}
-const AtomicString& HTMLImageElement::altText() const
-{
- // lets figure out the alt text.. magic stuff
- // http://www.w3.org/TR/1998/REC-html40-19980424/appendix/notes.html#altgen
- // also heavily discussed by Hixie on bugzilla
- const AtomicString& alt = getAttribute(HTMLNames::altAttr);
- if (!alt.isNull())
- return alt;
- // fall back to title attribute
- return getAttribute(HTMLNames::titleAttr);
-}
-
RenderObject* HTMLImageElement::createRenderer(RenderStyle* style)
{
RenderImage* image = new RenderImage(this);
@@ -199,13 +184,8 @@ void HTMLImageElement::attach(const AttachContext& context)
if (renderImageResource->hasImage())
return;
- // If we have no image at all because we have no src attribute, set
- // image height and width for the alt text instead.
- if (!imageLoader().image() && !renderImageResource->cachedImage())
- renderImage->setImageSizeForAltText();
- else
+ if (imageLoader().image() || renderImageResource->cachedImage())
renderImageResource->setImageResource(imageLoader().image());
-
}
}
« no previous file with comments | « sky/engine/core/html/HTMLImageElement.h ('k') | sky/engine/core/rendering/RenderImage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698