Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 71593002: Re-enable the newlines.vtt WebVTT parsing test (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
CC:
blink-reviews, feature-media-reviews_chromium.org, nessy, vcarbune.chromium, philipj_slow
Base URL:
https://chromium.googlesource.com/chromium/blink.git@newlines-svn
Visibility:
Public.

Description

Re-enable the newlines.vtt WebVTT parsing test With the correct newlines.vtt, the test simply passes. BUG=318734 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161957

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/media/track/opera/track/webvtt/parsing/support/cue-counts.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
The last step of fixing this. (I'm lining up the reviews first to save some ...
7 years, 1 month ago (2013-11-13 14:37:20 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 1 month ago (2013-11-13 14:38:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/71593002/1
7 years, 1 month ago (2013-11-13 20:00:07 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 22:04:19 UTC) #4
Message was sent while issue was closed.
Change committed as 161957

Powered by Google App Engine
This is Rietveld 408576698