Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: LayoutTests/fast/dom/HTMLImageElement/image-sizes-2x.html

Issue 715863004: Update a couple more tests for load completion definition change (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/dom/HTMLImageElement/image-sizes-js-change.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/dom/HTMLImageElement/image-sizes-2x.html
diff --git a/LayoutTests/fast/dom/HTMLImageElement/image-sizes-2x.html b/LayoutTests/fast/dom/HTMLImageElement/image-sizes-2x.html
index 609844f6e2708a7ebd9155c7218b13a0e1873732..8c7494769296a3733391718019bc4f43e5760c4e 100644
--- a/LayoutTests/fast/dom/HTMLImageElement/image-sizes-2x.html
+++ b/LayoutTests/fast/dom/HTMLImageElement/image-sizes-2x.html
@@ -4,10 +4,13 @@
</script>
<script src="../../hidpi/resources/srcset-helper.js"></script>
<script src="../../../resources/js-test.js"></script>
+<script src="../../../resources/run-after-display.js"></script>
dcheng 2014/11/12 21:30:33 This doesn't seem to be used.
<script src="resources/currentSrcHelper.js"></script>
<script>
if (window.testRunner)
testRunner.dumpAsText();
+ window.manualNotifyDone = true;
dcheng 2014/11/12 21:30:33 srcset-helper.js doesn't (seem) to be widely used
Nate Chapin 2014/11/12 21:33:28 It's used in ~50 tests. I can do that if you reall
dcheng 2014/11/12 21:43:41 Codesearch fail =/ Would it be possible to just t
+ var reloaded = sessionStorage.pageReloaded;
dcheng 2014/11/12 21:30:33 Yikes, magic variables =/
addEventListener("load", function() {
shouldBe('document.getElementById("simple").clientWidth', 'window.innerWidth');
@@ -34,6 +37,9 @@
shouldBe('currentSrcFileNameNoParams("half_size")', '"image-set-2x.png"');
shouldBe('document.getElementById("infitisimal_sizes").clientWidth', '(window.innerWidth/100)');
shouldBe('currentSrcFileNameNoParams("infitisimal_sizes")', '"image-set-2x.png"');
+
+ if (window.testRunner && reloaded)
+ testRunner.notifyDone();
}, false);
</script>
<img id="simple" src="" sizes="(max-width: 300px) 400px, 800px" srcset="../../hidpi/resources/image-set-1x.png?1 400w, ../../hidpi/resources/image-set-2x.png?1 800w">
« no previous file with comments | « no previous file | LayoutTests/fast/dom/HTMLImageElement/image-sizes-js-change.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698