Update a couple more tests for load completion definition change

Update a couple more tests for load completion definition change

BUG=426520
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185316

[Nate Chapin, 2014-11-12 19:13:49]

japhet@chromium.org changed reviewers:
+ dcheng@chromium.org

[Nate Chapin, 2014-11-12 19:13:50]

A couple more test updates that are blocking the removal of
ENABLE_LOAD_COMPLETION_HACKS

[dcheng, 2014-11-12 21:30:33]

https://codereview.chromium.org/715863004/diff/1/LayoutTests/fast/dom/HTMLIma...
File LayoutTests/fast/dom/HTMLImageElement/image-sizes-2x.html (right):

https://codereview.chromium.org/715863004/diff/1/LayoutTests/fast/dom/HTMLIma...
LayoutTests/fast/dom/HTMLImageElement/image-sizes-2x.html:7: <script
src="../../../resources/run-after-display.js"></script>
This doesn't seem to be used.

https://codereview.chromium.org/715863004/diff/1/LayoutTests/fast/dom/HTMLIma...
LayoutTests/fast/dom/HTMLImageElement/image-sizes-2x.html:12:
window.manualNotifyDone = true;
srcset-helper.js doesn't (seem) to be widely used yet. Would it be possible to
update the tests that use it so we don't need this magic variable?

https://codereview.chromium.org/715863004/diff/1/LayoutTests/fast/dom/HTMLIma...
LayoutTests/fast/dom/HTMLImageElement/image-sizes-2x.html:13: var reloaded =
sessionStorage.pageReloaded;
Yikes, magic variables =/

[Nate Chapin, 2014-11-12 21:33:29]

https://codereview.chromium.org/715863004/diff/1/LayoutTests/fast/dom/HTMLIma...
File LayoutTests/fast/dom/HTMLImageElement/image-sizes-2x.html (right):

https://codereview.chromium.org/715863004/diff/1/LayoutTests/fast/dom/HTMLIma...
LayoutTests/fast/dom/HTMLImageElement/image-sizes-2x.html:12:
window.manualNotifyDone = true;
On 2014/11/12 21:30:33, dcheng wrote:
> srcset-helper.js doesn't (seem) to be widely used yet. Would it be possible to
> update the tests that use it so we don't need this magic variable?

It's used in ~50 tests. I can do that if you really want, but I dispute your
definition of "widely used" :)

[dcheng, 2014-11-12 21:43:41]

https://codereview.chromium.org/715863004/diff/1/LayoutTests/fast/dom/HTMLIma...
File LayoutTests/fast/dom/HTMLImageElement/image-sizes-2x.html (right):

https://codereview.chromium.org/715863004/diff/1/LayoutTests/fast/dom/HTMLIma...
LayoutTests/fast/dom/HTMLImageElement/image-sizes-2x.html:12:
window.manualNotifyDone = true;
On 2014/11/12 at 21:33:28, Nate Chapin wrote:
> On 2014/11/12 21:30:33, dcheng wrote:
> > srcset-helper.js doesn't (seem) to be widely used yet. Would it be possible
to
> > update the tests that use it so we don't need this magic variable?
> 
> It's used in ~50 tests. I can do that if you really want, but I dispute your
definition of "widely used" :)

Codesearch fail =/

Would it be possible to just to wrap the notifyDone() in srcset-helper.js in a
setTimeout(..., 0) then?

[Nate Chapin, 2014-11-13 19:02:42]

This patch no longer needs to introduce new uses of manualNotifyDone, but I
don't immediately see how to drop the existing usage.

[dcheng, 2014-11-13 19:09:22]

LGTM.

[Nate Chapin, 2014-11-13 19:12:49]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2014-11-13 19:13:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/715863004/20001

[commit-bot: I haz the power, 2014-11-13 20:14:53]

Committed patchset #2 (id:20001) as 185316