Issue 715833002: AbstractModule should accept a PassRefPtr

Issue 715833002: AbstractModule should accept a PassRefPtr (Closed)

Created:
6 years, 1 month ago by abarth-chromium

Modified:
6 years, 1 month ago

Reviewers:
esprehn, eseidel

CC:
esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

AbstractModule should accept a PassRefPtr The AbstractModule is taking a reference to the Document. It should take a PassRefPtr so that it can accept a floating reference. R=esprehn@chromium.org, eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/effe39fc45ebe71d321c21512c54d6677519f592

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -8 lines)			Patch
M	sky/engine/core/app/AbstractModule.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/app/AbstractModule.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/app/Application.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	sky/engine/core/app/Application.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/app/Module.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/engine/core/app/Module.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (1 generated)

eseidel

So AbstractModule owns the Document? If the document would otherwise die, AbstractModule should keep it ...

6 years, 1 month ago (2014-11-11 18:06:26 UTC) #4

abarth-chromium

On 2014/11/11 at 18:06:26, eseidel wrote: > So AbstractModule owns the Document? If the document ...

6 years, 1 month ago (2014-11-11 18:11:24 UTC) #5

abarth-chromium

6 years, 1 month ago (2014-11-12 00:04:07 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
effe39fc45ebe71d321c21512c54d6677519f592 (presubmit successful).