Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 715803002: DevTools: merge TracingTimelineModel into TimelineModel (Closed)

Created:
6 years, 1 month ago by yurys
Modified:
6 years, 1 month ago
Reviewers:
caseq, alph, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: merge TracingTimelineModel into TimelineModel Now that there is only one implementation it doesn't make sense to separate interface from implementation of TimelineModel. BUG=428700 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185130

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1289 lines, -1517 lines) Patch
M LayoutTests/http/tests/inspector/timeline-test.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/tracing-session-id.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/tracing-test.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/tracing/console-timeline.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/tracing/decode-resize.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/tracing/timeline-enum-stability.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/tracing/timeline-layout-with-invalidations.html View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-paint-with-layout-invalidations.html View 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-paint-with-layout-invalidations-on-deleted-node.html View 2 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-paint-with-style-recalc-invalidations.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-style-recalc-with-invalidations.html View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/tracing/update-layer-tree.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/virtual/implsidepainting/inspector/tracing/paint-command-log-nodes.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/devtools.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineEventOverview.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineFlameChart.js View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineFrameModel.js View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineJSProfile.js View 1 4 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 1 7 chunks +1203 lines, -126 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 5 chunks +7 lines, -8 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePresentationModel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 17 chunks +24 lines, -24 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineView.js View 1 chunk +1 line, -1 line 0 comments Download
D Source/devtools/front_end/timeline/TracingTimelineModel.js View 1 1 chunk +0 lines, -1302 lines 0 comments Download
M Source/devtools/front_end/timeline/module.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
yurys
6 years, 1 month ago (2014-11-11 12:23:43 UTC) #2
loislo
lgtm https://codereview.chromium.org/715803002/diff/1/Source/devtools/front_end/timeline/TimelinePanel.js File Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/715803002/diff/1/Source/devtools/front_end/timeline/TimelinePanel.js#newcode54 Source/devtools/front_end/timeline/TimelinePanel.js:54: this._tracingTimelineModel = new WebInspector.TimelineModel(this._tracingManager, this._tracingModel, WebInspector.TimelineUIUtils.hiddenRecordsFilter()); this._timelineModel
6 years, 1 month ago (2014-11-11 12:33:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715803002/20001
6 years, 1 month ago (2014-11-11 12:58:00 UTC) #5
yurys
https://codereview.chromium.org/715803002/diff/1/Source/devtools/front_end/timeline/TimelinePanel.js File Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/715803002/diff/1/Source/devtools/front_end/timeline/TimelinePanel.js#newcode54 Source/devtools/front_end/timeline/TimelinePanel.js:54: this._tracingTimelineModel = new WebInspector.TimelineModel(this._tracingManager, this._tracingModel, WebInspector.TimelineUIUtils.hiddenRecordsFilter()); On 2014/11/11 12:33:06, ...
6 years, 1 month ago (2014-11-11 13:41:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/33000)
6 years, 1 month ago (2014-11-11 13:53:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715803002/20001
6 years, 1 month ago (2014-11-11 13:57:34 UTC) #10
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
6 years, 1 month ago (2014-11-11 13:58:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715803002/40001
6 years, 1 month ago (2014-11-11 14:00:39 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/35837)
6 years, 1 month ago (2014-11-11 15:43:04 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715803002/40001
6 years, 1 month ago (2014-11-11 15:50:41 UTC) #18
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 16:36:01 UTC) #19
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 185130

Powered by Google App Engine
This is Rietveld 408576698