Hotword Private API: Add support for retrieving localized strings.

Hotword Private API: Add support for retrieving localized strings.

BUG=390086
Committed: https://crrev.com/c486ecc954d19ec9ca2a3b46b7f4962d760b2a92
Cr-Commit-Position: refs/heads/master@{#303948}

[kcarattini, 2014-11-11 06:43:14]

kcarattini@chromium.org changed reviewers:
+ jhawkins@chromium.org, mpearson@chromium.org, rlp@chromium.org

[kcarattini, 2014-11-11 06:43:15]

rlp@chromium.org: Please review changes in 
hotword_private_api.h/cc
hotword_private.idl

mpearson@chromium.org: Please review changes in 
extension_function_histogram_value.h
histograms.xml

jhawkins@chromium.org: Please review changes in 
generated_resources.grd

[rpetterson, 2014-11-11 19:27:31]

https://codereview.chromium.org/715773002/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/715773002/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:15124: +      You're Chromebook can now:
You're -> Your

https://codereview.chromium.org/715773002/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:15135: +    <message
name="IDS_HOTWORD_OPT_IN_FINISHED_SETTINGS_LINK" desc="The end of the text
indicating where the user can change their settings. Also the name of the
chrome:settings page.">
Is there a reason this one (and audio history) is split from above rather than
using one string with a $1 replacement for the link?

[kcarattini, 2014-11-12 00:08:21]

https://codereview.chromium.org/715773002/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/715773002/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:15124: +      You're Chromebook can now:
On 2014/11/11 19:27:31, rpetterson wrote:
> You're -> Your

Done.

https://codereview.chromium.org/715773002/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:15135: +    <message
name="IDS_HOTWORD_OPT_IN_FINISHED_SETTINGS_LINK" desc="The end of the text
indicating where the user can change their settings. Also the name of the
chrome:settings page.">
On 2014/11/11 19:27:31, rpetterson wrote:
> Is there a reason this one (and audio history) is split from above rather than
> using one string with a $1 replacement for the link?

Done.

[rpetterson, 2014-11-12 01:22:17]

https://codereview.chromium.org/715773002/diff/20001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/715773002/diff/20001/chrome/app/generated_res...
chrome/app/generated_resources.grd:15133: +      You can change this at any time
in <ph name="BEGIN_LINK">&lt;a target="_blank" href="#" 
id="settings-link"&gt;</ph>Chrome Settings<ph
name="END_LINK">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph>
extra space between "#" and id?
Also, I think you can just say href="chrome://settings" and then you don't need
the extra handler hotword_audio_verification/main.js.

[kcarattini, 2014-11-12 01:40:07]

Added the strings for the Audio History page as well.

https://codereview.chromium.org/715773002/diff/20001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/715773002/diff/20001/chrome/app/generated_res...
chrome/app/generated_resources.grd:15133: +      You can change this at any time
in <ph name="BEGIN_LINK">&lt;a target="_blank" href="#" 
id="settings-link"&gt;</ph>Chrome Settings<ph
name="END_LINK">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph>
On 2014/11/12 01:22:17, rpetterson wrote:
> extra space between "#" and id?

Done.

> Also, I think you can just say href="chrome://settings" and then you don't
need
> the extra handler hotword_audio_verification/main.js.

This doesn't work from a chrome app. had a discussion with the Apps team and the
only way to open a chrome: link from an app is through the chrome.browser API.

[Mark P, 2014-11-12 19:07:09]

histograms.xml lgtm

[rpetterson, 2014-11-12 20:27:47]

lgtm

[James Hawkins, 2014-11-12 22:36:53]

lgtm

[kcarattini, 2014-11-12 23:55:51]

The CQ bit was checked by kcarattini@chromium.org

[commit-bot: I haz the power, 2014-11-12 23:56:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/715773002/60001

[commit-bot: I haz the power, 2014-11-13 00:58:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-11-13 01:00:24]

Patchset 4 (id:??) landed as
https://crrev.com/c486ecc954d19ec9ca2a3b46b7f4962d760b2a92
Cr-Commit-Position: refs/heads/master@{#303948}