Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Unified Diff: components/autofill/content/renderer/page_click_tracker.h

Issue 715733002: [Android] Show autofill popup after animation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/page_click_tracker.h
diff --git a/components/autofill/content/renderer/page_click_tracker.h b/components/autofill/content/renderer/page_click_tracker.h
index 0bcc0f6299b1a06f21bf5dbe248c311f0c25a834..9cb63535f64a64c36b1abb09595f3b393f75feca 100644
--- a/components/autofill/content/renderer/page_click_tracker.h
+++ b/components/autofill/content/renderer/page_click_tracker.h
@@ -16,7 +16,7 @@ namespace autofill {
class PageClickListener;
-// This class is responsible notifiying the associated listener when a node is
+// This class is responsible notifying the associated listener when a node is
// clicked or tapped. It also tracks whether a node was focused before the event
// was handled.
//
@@ -39,12 +39,14 @@ class PageClickTracker : public content::RenderViewObserver {
void DidHandleMouseEvent(const blink::WebMouseEvent& event) override;
void DidHandleGestureEvent(const blink::WebGestureEvent& event) override;
void FocusedNodeChanged(const blink::WebNode& node) override;
+ void FocusChangeComplete() override;
// Called there is a tap or click at |x|, |y|.
void PotentialActivationAt(int x, int y);
- // Sets |was_focused_before_now_| to true.
- void SetWasFocused();
+ // The node that was clicked. Non-null only when the animations caused by
+ // focus change are still ongoing.
+ blink::WebNode clicked_node_;
// This is set to false when the focus changes, then set back to true soon
// afterwards. This helps track whether an event happened after a node was
@@ -54,8 +56,6 @@ class PageClickTracker : public content::RenderViewObserver {
// The listener getting the actual notifications.
PageClickListener* listener_;
- base::WeakPtrFactory<PageClickTracker> weak_ptr_factory_;
-
DISALLOW_COPY_AND_ASSIGN(PageClickTracker);
};
« no previous file with comments | « components/autofill/content/renderer/form_autofill_util.cc ('k') | components/autofill/content/renderer/page_click_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698