[Android] Show autofill popup after animation.

components/autofill/content/renderer/autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_split.h"
@@ skipping 210 matching lines @@
 
 void AutofillAgent::FocusedNodeChanged(const WebNode& node) {
   HidePopup();
 
   if (node.isNull() || !node.isElementNode())
     return;
 
   if (node.document().frame() != render_frame()->GetWebFrame())
     return;
 
-  if (password_generation_agent_ &&
-      password_generation_agent_->FocusedNodeHasChanged(node)) {
-    is_popup_possibly_visible_ = true;
-    return;
-  }
-
   WebElement web_element = node.toConst<WebElement>();
 
   if (!web_element.document().frame())
     return;
 
   const WebInputElement* element = toWebInputElement(&web_element);
 
   if (!element || !element->isEnabled() || element->isReadOnly() ||
       !element->isTextField() || element->isPasswordField())
     return;
 
   element_ = *element;
 }
 
 void AutofillAgent::OrientationChangeEvent() {

[aelias_OOO_until_Jul13, 2014/12/16 23:15:49]

Can we delete this one?  It seems redundant with the resize mechanism.

[please use gerrit instead, 2014/12/16 23:39:22]

Evan is removing it in https://codereview.chromium.org/809623005/.

   HidePopup();
 }
 
-void AutofillAgent::Resized() {
+void AutofillAgent::FocusedElementMovedOnResize() {
   HidePopup();
 }
 
 void AutofillAgent::LegacyFrameWillClose(blink::WebFrame* frame) {
   if (in_flight_request_form_.isNull())
     return;
 
   for (blink::WebFrame* temp = render_frame()->GetWebFrame(); temp;
        temp = temp->parent()) {
     if (temp == frame) {
@@ skipping 66 matching lines @@
     const WebFormControlElement& element,
     bool was_focused) {
   // TODO(estade): Remove this check when PageClickTracker is per-frame.
   if (element.document().frame() != render_frame()->GetWebFrame())
     return;
 
   const WebInputElement* input_element = toWebInputElement(&element);
   if (!input_element && !IsTextAreaElement(element))
     return;
 
+  if (password_generation_agent_ &&
+      password_generation_agent_->FocusedNodeHasChanged(*input_element)) {
+    is_popup_possibly_visible_ = true;
+    return;
+  }
+
   ShowSuggestionsOptions options;
   options.autofill_on_empty_values = true;
   options.display_warning_if_disabled = true;
   options.show_full_suggestion_list = element.isAutofilled();
 
   if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnableSingleClickAutofill)) {
     // Show full suggestions when clicking on an already-focused form field. On
     // the initial click (not focused yet), only show password suggestions.
-#if defined(OS_ANDROID)
-    // TODO(gcasto): Remove after crbug.com/430318 has been fixed.
-    if (!was_focused)
-      return;
-#endif
-
     options.show_full_suggestion_list =
         options.show_full_suggestion_list || was_focused;
     options.show_password_suggestions_only = !was_focused;
   }
   ShowSuggestions(element, options);
 }
 
 void AutofillAgent::textFieldDidEndEditing(const WebInputElement& element) {
   password_autofill_agent_->TextFieldDidEndEditing(element);
   has_shown_autofill_popup_for_current_edit_ = false;
@@ skipping 462 matching lines @@
 
 void AutofillAgent::LegacyAutofillAgent::FocusedNodeChanged(
     const WebNode& node) {
   agent_->FocusedNodeChanged(node);
 }
 
 void AutofillAgent::LegacyAutofillAgent::OrientationChangeEvent() {
   agent_->OrientationChangeEvent();
 }
 
-void AutofillAgent::LegacyAutofillAgent::Resized() {
-  agent_->Resized();
+void AutofillAgent::LegacyAutofillAgent::FocusedElementMovedOnResize() {
+  agent_->FocusedElementMovedOnResize();
 }
 
 void AutofillAgent::LegacyAutofillAgent::FrameWillClose(
     blink::WebFrame* frame) {
   agent_->LegacyFrameWillClose(frame);
 }
 
 }  // namespace autofill