cc/trees/thread_proxy.cc - Issue 715733002: [Android] Show autofill popup after animation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/trees/thread_proxy.cc

Issue 715733002: [Android] Show autofill popup after animation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2011 The Chromium Authors. All rights reserved.	1 // Copyright 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "cc/trees/thread_proxy.h"	5 #include "cc/trees/thread_proxy.h"

6	6

7 #include <algorithm>	7 #include <algorithm>

8 #include <string>	8 #include <string>

9	9

10 #include "base/auto_reset.h"	10 #include "base/auto_reset.h"

(...skipping 1321 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1332 }	1332 }

1333	1333

1334 impl().timing_history.DidActivateSyncTree();	1334 impl().timing_history.DidActivateSyncTree();

1335 }	1335 }

1336	1336

1337 void ThreadProxy::DidManageTiles() {	1337 void ThreadProxy::DidManageTiles() {

1338 DCHECK(IsImplThread());	1338 DCHECK(IsImplThread());

1339 impl().scheduler->DidManageTiles();	1339 impl().scheduler->DidManageTiles();

1340 }	1340 }

1341	1341

	1342 void ThreadProxy::DidCompletePageScaleAnimationBeforeCommit() {
	aelias_OOO_until_Jul13 2014/11/22 03:38:11 This is called from the impl thread, so it should This is called from the impl thread, so it should have "OnImplThread" in the name. please use gerrit instead 2014/11/24 20:22:31 Done. Show quoted text On 2014/11/22 03:38:11, aelias wrote: > This is called from the impl thread, so it should have "OnImplThread" in the > name. Done.
	1343 layer_tree_host()->DidCompletePageScaleAnimationBeforeCommit();
	aelias_OOO_until_Jul13 2014/11/22 03:38:11 You shouldn't directly access the LayerTreeHost fr You shouldn't directly access the LayerTreeHost from the impl thread, it must only be accessed from the main thread. You should post a task on the main-thread that calls this instead. please use gerrit instead 2014/11/24 20:22:31 Done. Show quoted text On 2014/11/22 03:38:11, aelias wrote: > You shouldn't directly access the LayerTreeHost from the impl thread, it must > only be accessed from the main thread. You should post a task on the > main-thread that calls this instead. Done.
	1344 }

	1345

1342 } // namespace cc	1346 } // namespace cc

OLD	NEW