[Android] Show autofill popup after animation.

chrome/renderer/autofill/password_generation_agent_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string.h>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/histogram_tester.h"
 #include "chrome/test/base/chrome_render_view_test.h"
@@ skipping 67 matching lines @@
     if (available) {
       ASSERT_EQ(1u, password_generation_->messages().size());
       EXPECT_EQ(AutofillHostMsg_ShowPasswordGenerationPopup::ID,
                 password_generation_->messages()[0]->type());
     } else {
       EXPECT_EQ(0u, password_generation_->messages().size());
     }
     password_generation_->clear_messages();
   }
 
+  void LoadHTMLWithUserGesture(const char* html) {
+    LoadHTML(html);
+
+    // Enable show-ime event when element is focused by indicating that a user
+    // gesture has been processed since load.
+    EXPECT_TRUE(SimulateElementClick("dummy"));
+  }
+
  private:
   DISALLOW_COPY_AND_ASSIGN(PasswordGenerationAgentTest);
 };
 
 const char kSigninFormHTML[] =
     "<FORM name = 'blah' action = 'http://www.random.com/'> "
     "  <INPUT type = 'text' id = 'username'/> "
     "  <INPUT type = 'password' id = 'password'/> "
+    "  <INPUT type = 'button' id = 'dummy'/> "
     "  <INPUT type = 'submit' value = 'LOGIN' />"
     "</FORM>";
 
 const char kAccountCreationFormHTML[] =
     "<FORM name = 'blah' action = 'http://www.random.com/'> "
     "  <INPUT type = 'text' id = 'username'/> "
     "  <INPUT type = 'password' id = 'first_password' "
     "         autocomplete = 'off' size = 5/>"
     "  <INPUT type = 'password' id = 'second_password' size = 5/> "
     "  <INPUT type = 'text' id = 'address'/> "
+    "  <INPUT type = 'button' id = 'dummy'/> "
     "  <INPUT type = 'submit' value = 'LOGIN' />"
     "</FORM>";
 
 const char kHiddenPasswordAccountCreationFormHTML[] =
     "<FORM name = 'blah' action = 'http://www.random.com/'> "
     "  <INPUT type = 'text' id = 'username'/> "
     "  <INPUT type = 'password' id = 'first_password'/> "
     "  <INPUT type = 'password' id = 'second_password' style='display:none'/> "
+    "  <INPUT type = 'button' id = 'dummy'/> "
     "  <INPUT type = 'submit' value = 'LOGIN' />"
     "</FORM>";
 
 const char kInvalidActionAccountCreationFormHTML[] =
     "<FORM name = 'blah' action = 'invalid'> "
     "  <INPUT type = 'text' id = 'username'/> "
     "  <INPUT type = 'password' id = 'first_password'/> "
     "  <INPUT type = 'password' id = 'second_password'/> "
+    "  <INPUT type = 'button' id = 'dummy'/> "
     "  <INPUT type = 'submit' value = 'LOGIN' />"
     "</FORM>";
 
 const char kMultipleAccountCreationFormHTML[] =
     "<FORM name = 'login' action = 'http://www.random.com/'> "
     "  <INPUT type = 'text' id = 'random'/> "
     "  <INPUT type = 'text' id = 'username'/> "
     "  <INPUT type = 'password' id = 'password'/> "
+    "  <INPUT type = 'button' id = 'dummy'/> "
     "  <INPUT type = 'submit' value = 'LOGIN' />"
     "</FORM>"
     "<FORM name = 'signup' action = 'http://www.random.com/signup'> "
     "  <INPUT type = 'text' id = 'username'/> "
     "  <INPUT type = 'password' id = 'first_password' "
     "         autocomplete = 'off' size = 5/>"
     "  <INPUT type = 'password' id = 'second_password' size = 5/> "
     "  <INPUT type = 'text' id = 'address'/> "
     "  <INPUT type = 'submit' value = 'LOGIN' />"
     "</FORM>";
 
 const char ChangeDetectionScript[] =
     "<script>"
     "  firstOnChangeCalled = false;"
     "  secondOnChangeCalled = false;"
     "  document.getElementById('first_password').onchange = function() {"
     "    firstOnChangeCalled = true;"
     "  };"
     "  document.getElementById('second_password').onchange = function() {"
     "    secondOnChangeCalled = true;"
     "  };"
     "</script>";
 
 TEST_F(PasswordGenerationAgentTest, DetectionTest) {
   // Don't shown the icon for non account creation forms.
-  LoadHTML(kSigninFormHTML);
+  LoadHTMLWithUserGesture(kSigninFormHTML);
   ExpectPasswordGenerationAvailable("password", false);
 
   // We don't show the decoration yet because the feature isn't enabled.
-  LoadHTML(kAccountCreationFormHTML);
+  LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   ExpectPasswordGenerationAvailable("first_password", false);
 
   // Pretend like We have received message indicating site is not blacklisted,
   // and we have received message indicating the form is classified as
   // ACCOUNT_CREATION_FORM form Autofill server. We should show the icon.
-  LoadHTML(kAccountCreationFormHTML);
+  LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   SetNotBlacklistedMessage(kAccountCreationFormHTML);
   SetAccountCreationFormsDetectedMessage(0);
   ExpectPasswordGenerationAvailable("first_password", true);
 
   // Hidden fields are not treated differently.
-  LoadHTML(kHiddenPasswordAccountCreationFormHTML);
+  LoadHTMLWithUserGesture(kHiddenPasswordAccountCreationFormHTML);
   SetNotBlacklistedMessage(kHiddenPasswordAccountCreationFormHTML);
   SetAccountCreationFormsDetectedMessage(0);
   ExpectPasswordGenerationAvailable("first_password", true);
 
   // This doesn't trigger because the form action is invalid.
-  LoadHTML(kInvalidActionAccountCreationFormHTML);
+  LoadHTMLWithUserGesture(kInvalidActionAccountCreationFormHTML);
   SetNotBlacklistedMessage(kInvalidActionAccountCreationFormHTML);
   SetAccountCreationFormsDetectedMessage(0);
   ExpectPasswordGenerationAvailable("first_password", false);
 }
 
 TEST_F(PasswordGenerationAgentTest, FillTest) {
   // Make sure that we are enabled before loading HTML.
   std::string html = std::string(kAccountCreationFormHTML) +
       ChangeDetectionScript;
-  LoadHTML(html.c_str());
+  LoadHTMLWithUserGesture(html.c_str());
   SetNotBlacklistedMessage(html.c_str());
   SetAccountCreationFormsDetectedMessage(0);
 
   WebDocument document = GetMainFrame()->document();
   WebElement element =
       document.getElementById(WebString::fromUTF8("first_password"));
   ASSERT_FALSE(element.isNull());
   WebInputElement first_password_element = element.to<WebInputElement>();
   element = document.getElementById(WebString::fromUTF8("second_password"));
   ASSERT_FALSE(element.isNull());
@@ skipping 29 matching lines @@
 
   // Focus moved to the next input field.
   // TODO(zysxqn): Change this back to the address element once Bug 90224
   // https://bugs.webkit.org/show_bug.cgi?id=90224 has been fixed.
   element = document.getElementById(WebString::fromUTF8("first_password"));
   ASSERT_FALSE(element.isNull());
   EXPECT_EQ(element, document.focusedElement());
 }
 
 TEST_F(PasswordGenerationAgentTest, EditingTest) {
-  LoadHTML(kAccountCreationFormHTML);
+  LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   SetNotBlacklistedMessage(kAccountCreationFormHTML);
   SetAccountCreationFormsDetectedMessage(0);
 
   WebDocument document = GetMainFrame()->document();
   WebElement element =
       document.getElementById(WebString::fromUTF8("first_password"));
   ASSERT_FALSE(element.isNull());
   WebInputElement first_password_element = element.to<WebInputElement>();
   element = document.getElementById(WebString::fromUTF8("second_password"));
   ASSERT_FALSE(element.isNull());
@@ skipping 29 matching lines @@
   // textFieldDidChange posts a task, so we need to wait until it's been
   // processed.
   base::MessageLoop::current()->RunUntilIdle();
   EXPECT_EQ(empty_password, first_password_element.value());
   EXPECT_EQ(empty_password, second_password_element.value());
 }
 
 TEST_F(PasswordGenerationAgentTest, BlacklistedTest) {
   // Did not receive not blacklisted message. Don't show password generation
   // icon.
-  LoadHTML(kAccountCreationFormHTML);
+  LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   SetAccountCreationFormsDetectedMessage(0);
   ExpectPasswordGenerationAvailable("first_password", false);
 
   // Receive one not blacklisted message for non account creation form. Don't
   // show password generation icon.
-  LoadHTML(kAccountCreationFormHTML);
+  LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   SetNotBlacklistedMessage(kSigninFormHTML);
   SetAccountCreationFormsDetectedMessage(0);
   ExpectPasswordGenerationAvailable("first_password", false);
 
-  // Receive one not blackliste message for account creation form. Show password
-  // generation icon.
-  LoadHTML(kAccountCreationFormHTML);
+  // Receive one not blacklisted message for account creation form. Show
+  // password generation icon.
+  LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   SetNotBlacklistedMessage(kAccountCreationFormHTML);
   SetAccountCreationFormsDetectedMessage(0);
   ExpectPasswordGenerationAvailable("first_password", true);
 
   // Receive two not blacklisted messages, one is for account creation form and
   // the other is not. Show password generation icon.
-  LoadHTML(kAccountCreationFormHTML);
+  LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   SetNotBlacklistedMessage(kAccountCreationFormHTML);
   SetNotBlacklistedMessage(kSigninFormHTML);
   SetAccountCreationFormsDetectedMessage(0);
   ExpectPasswordGenerationAvailable("first_password", true);
 }
 
 TEST_F(PasswordGenerationAgentTest, AccountCreationFormsDetectedTest) {
-  // Did not receive account creation forms detected messege. Don't show
+  // Did not receive account creation forms detected message. Don't show
   // password generation icon.
-  LoadHTML(kAccountCreationFormHTML);
+  LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   SetNotBlacklistedMessage(kAccountCreationFormHTML);
   ExpectPasswordGenerationAvailable("first_password", false);
 
   // Receive the account creation forms detected message. Show password
   // generation icon.
-  LoadHTML(kAccountCreationFormHTML);
+  LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   SetNotBlacklistedMessage(kAccountCreationFormHTML);
   SetAccountCreationFormsDetectedMessage(0);
   ExpectPasswordGenerationAvailable("first_password", true);
 }
 
 TEST_F(PasswordGenerationAgentTest, MaximumOfferSize) {
   base::HistogramTester histogram_tester;
 
-  LoadHTML(kAccountCreationFormHTML);
+  LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   SetNotBlacklistedMessage(kAccountCreationFormHTML);
   SetAccountCreationFormsDetectedMessage(0);
   ExpectPasswordGenerationAvailable("first_password", true);
 
   WebDocument document = GetMainFrame()->document();
   WebElement element =
       document.getElementById(WebString::fromUTF8("first_password"));
   ASSERT_FALSE(element.isNull());
   WebInputElement first_password_element = element.to<WebInputElement>();
 
@@ skipping 47 matching lines @@
   password_generation_->clear_messages();
 
   // Change focus. Bubble should be hidden, but that is handled by AutofilAgent,
   // so no messages are sent.
   ExecuteJavaScript("document.getElementById('username').focus();");
   EXPECT_EQ(0u, password_generation_->messages().size());
   password_generation_->clear_messages();
 
   // Focusing the password field will bring up the generation UI again.
   ExecuteJavaScript("document.getElementById('first_password').focus();");
-  EXPECT_EQ(1u, password_generation_->messages().size());
+  ASSERT_EQ(1u, password_generation_->messages().size());
   EXPECT_EQ(AutofillHostMsg_ShowPasswordGenerationPopup::ID,
             password_generation_->messages()[0]->type());
   password_generation_->clear_messages();
 
   // Loading a different page triggers UMA stat upload. Verify that only one
   // display event is sent even though
-  LoadHTML(kSigninFormHTML);
+  LoadHTMLWithUserGesture(kSigninFormHTML);
 
   histogram_tester.ExpectBucketCount(
       "PasswordGeneration.Event",
       autofill::password_generation::GENERATION_POPUP_SHOWN,
       1);
 }
 
 TEST_F(PasswordGenerationAgentTest, DynamicFormTest) {
-  LoadHTML(kSigninFormHTML);
+  LoadHTMLWithUserGesture(kSigninFormHTML);
   SetNotBlacklistedMessage(kSigninFormHTML);
 
   ExecuteJavaScript(
       "var form = document.createElement('form');"
       "var username = document.createElement('input');"
       "username.type = 'text';"
       "username.id = 'dynamic_username';"
       "var first_password = document.createElement('input');"
       "first_password.type = 'password';"
       "first_password.id = 'first_password';"
       "first_password.name = 'first_password';"
       "var second_password = document.createElement('input');"
       "second_password.type = 'password';"
       "second_password.id = 'second_password';"
       "second_password.name = 'second_password';"
       "form.appendChild(username);"
       "form.appendChild(first_password);"
       "form.appendChild(second_password);"
       "document.body.appendChild(form);");
   ProcessPendingMessages();
 
   // This needs to come after the DOM has been modified.
   SetAccountCreationFormsDetectedMessage(1);
 
-  // TODO(gcasto): I'm slighty worried about flakes in this test where
+  // TODO(gcasto): I'm slightly worried about flakes in this test where
   // didAssociateFormControls() isn't called. If this turns out to be a problem
   // adding a call to OnDynamicFormsSeen(GetMainFrame()) will fix it, though
   // it will weaken the test.
   ExpectPasswordGenerationAvailable("first_password", true);
 }
 
 TEST_F(PasswordGenerationAgentTest, MultiplePasswordFormsTest) {
   // If two forms on the page looks like possible account creation forms, make
   // sure to trigger on the one that is specified from Autofill.
-  LoadHTML(kMultipleAccountCreationFormHTML);
+  LoadHTMLWithUserGesture(kMultipleAccountCreationFormHTML);
   SetNotBlacklistedMessage(kMultipleAccountCreationFormHTML);
 
   // Should trigger on the second form.
   SetAccountCreationFormsDetectedMessage(1);
 
   ExpectPasswordGenerationAvailable("password", false);
   ExpectPasswordGenerationAvailable("first_password", true);
 }
 
 TEST_F(PasswordGenerationAgentTest, MessagesAfterAccountSignupFormFound) {
-  LoadHTML(kAccountCreationFormHTML);
+  LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   SetNotBlacklistedMessage(kAccountCreationFormHTML);
   SetAccountCreationFormsDetectedMessage(0);
 
   // Generation should be enabled.
   ExpectPasswordGenerationAvailable("first_password", true);
 
   // Extra not blacklisted messages can be sent. Make sure that they are handled
   // correctly (generation should still be available).
   SetNotBlacklistedMessage(kAccountCreationFormHTML);
 
   // Need to focus another field first for verification to work.
   ExpectPasswordGenerationAvailable("second_password", false);
   ExpectPasswordGenerationAvailable("first_password", true);
 }
 
 }  // namespace autofill