Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 71573002: Fix shared library build after r17696 (Closed)

Created:
7 years, 1 month ago by rmcilroy
Modified:
7 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Fix shared library build after r17696 R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17700

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/d8.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmcilroy
7 years, 1 month ago (2013-11-13 14:23:20 UTC) #1
rmcilroy
Sven: PTAL - I accidentally broke the shared library build with the previous commit.
7 years, 1 month ago (2013-11-13 14:25:52 UTC) #2
ulan
lgtm
7 years, 1 month ago (2013-11-13 15:00:42 UTC) #3
rmcilroy
7 years, 1 month ago (2013-11-13 15:32:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r17700.

Powered by Google App Engine
This is Rietveld 408576698