Navigation transitions (web to native app): Hide/Show transition elements (Blink side)

Source/web/WebDocument.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 278 matching lines @@
     unwrap<Document>()->setIsTransitionDocument();
 }
 
 void WebDocument::beginExitTransition(const WebString& cssSelector)
 {
     RefPtrWillBeRawPtr<Document> document = unwrap<Document>();
     document->hideTransitionElements(cssSelector);
     document->styleEngine()->enableExitTransitionStylesheets();
 }
 
+void WebDocument::hideTransitionElements(const WebString& cssSelector)
+{
+    RefPtrWillBeRawPtr<Document> document = unwrap<Document>();
+    document->hideTransitionElements(cssSelector);
+}
+
+void WebDocument::showTransitionElements(const WebString& cssSelector)
+{
+    RefPtrWillBeRawPtr<Document> document = unwrap<Document>();
+    document->hideTransitionElements(cssSelector);

[shatch, 2014/11/13 14:38:34]

Should this be showTransitionElements?

[Zhen Wang, 2014/11/13 15:42:49]

Oh, right. I will fix this. Is there a way to test the interface to avoid this
kind of mistake?

[Zhen Wang, 2014/11/13 21:55:10]

As a note, this is fixed in https://codereview.chromium.org/723073003/

+}
+
 WebAXObject WebDocument::accessibilityObject() const
 {
     const Document* document = constUnwrap<Document>();
     AXObjectCache* cache = document->axObjectCache();
     return cache ? WebAXObject(cache->getOrCreateAXObjectFromRenderView(document->renderView())) : WebAXObject();
 }
 
 WebAXObject WebDocument::accessibilityObjectFromID(int axID) const
 {
     const Document* document = constUnwrap<Document>();
@@ skipping 52 matching lines @@
     m_private = elem;
     return *this;
 }
 
 WebDocument::operator PassRefPtrWillBeRawPtr<Document>() const
 {
     return toDocument(m_private.get());
 }
 
 } // namespace blink