Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 715653004: Navigation transitions (web to native app): Hide/Show transition elements (Blink side) (Closed)

Created:
6 years, 1 month ago by Zhen Wang
Modified:
6 years, 1 month ago
Reviewers:
Nate Chapin, shatch
CC:
blink-reviews, rwlbuis, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, sof, eae+blinkwatch, dglazkov+blink, dstockwell, Timothy Loh, blink-reviews-dom_chromium.org, Inactive, darktears, arv+blink, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Navigation transitions (web to native app): Hide/Show transition elements (Blink side) We need a way to show hidden transition elements when coming back from native app (when back button is pressed). This is the Blink side of the CL. The Chrome side is here: https://codereview.chromium.org/712183002/ BUG=370696 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185162

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase to take changes in 654953002 #

Patch Set 3 : review fix #

Total comments: 2

Patch Set 4 : add helper function #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -2 lines) Patch
M LayoutTests/fast/html/navigation-transition.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/html/navigation-transition-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Document.h View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 2 chunks +12 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebDocument.cpp View 1 2 1 chunk +12 lines, -0 lines 3 comments Download
M public/web/WebDocument.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
Zhen Wang
Hi Nate, since you have reviewed some nav trans CLs, do you mind reviewing some ...
6 years, 1 month ago (2014-11-11 15:20:55 UTC) #2
Nate Chapin
https://codereview.chromium.org/715653004/diff/1/Source/core/dom/Document.h File Source/core/dom/Document.h (right): https://codereview.chromium.org/715653004/diff/1/Source/core/dom/Document.h#newcode387 Source/core/dom/Document.h:387: void updateTransitionElementOpacity(const AtomicString& cssSelector, const double opacity); Is there ...
6 years, 1 month ago (2014-11-11 19:35:58 UTC) #3
Zhen Wang
https://codereview.chromium.org/715653004/diff/1/Source/core/dom/Document.h File Source/core/dom/Document.h (right): https://codereview.chromium.org/715653004/diff/1/Source/core/dom/Document.h#newcode387 Source/core/dom/Document.h:387: void updateTransitionElementOpacity(const AtomicString& cssSelector, const double opacity); Change it ...
6 years, 1 month ago (2014-11-11 22:15:49 UTC) #5
Nate Chapin
lgtm https://codereview.chromium.org/715653004/diff/60001/Source/core/dom/Document.cpp File Source/core/dom/Document.cpp (right): https://codereview.chromium.org/715653004/diff/60001/Source/core/dom/Document.cpp#newcode5662 Source/core/dom/Document.cpp:5662: void Document::showTransitionElements(const AtomicString& cssSelector) It might be good ...
6 years, 1 month ago (2014-11-11 22:18:56 UTC) #6
Zhen Wang
https://codereview.chromium.org/715653004/diff/60001/Source/core/dom/Document.cpp File Source/core/dom/Document.cpp (right): https://codereview.chromium.org/715653004/diff/60001/Source/core/dom/Document.cpp#newcode5662 Source/core/dom/Document.cpp:5662: void Document::showTransitionElements(const AtomicString& cssSelector) Added a helper function, which ...
6 years, 1 month ago (2014-11-11 22:55:58 UTC) #7
Nate Chapin
That seems reasonsable. LGTM
6 years, 1 month ago (2014-11-11 22:57:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715653004/80001
6 years, 1 month ago (2014-11-11 23:31:12 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:80001) as 185162
6 years, 1 month ago (2014-11-12 01:40:26 UTC) #11
shatch
https://codereview.chromium.org/715653004/diff/80001/Source/web/WebDocument.cpp File Source/web/WebDocument.cpp (right): https://codereview.chromium.org/715653004/diff/80001/Source/web/WebDocument.cpp#newcode308 Source/web/WebDocument.cpp:308: document->hideTransitionElements(cssSelector); Should this be showTransitionElements?
6 years, 1 month ago (2014-11-13 14:38:34 UTC) #13
Zhen Wang
https://codereview.chromium.org/715653004/diff/80001/Source/web/WebDocument.cpp File Source/web/WebDocument.cpp (right): https://codereview.chromium.org/715653004/diff/80001/Source/web/WebDocument.cpp#newcode308 Source/web/WebDocument.cpp:308: document->hideTransitionElements(cssSelector); Oh, right. I will fix this. Is there ...
6 years, 1 month ago (2014-11-13 15:42:49 UTC) #14
Zhen Wang
Oh, just found out WebDocumentTest.cpp. Will fix and add some test there.
6 years, 1 month ago (2014-11-13 16:12:06 UTC) #15
Zhen Wang
6 years, 1 month ago (2014-11-13 21:55:10 UTC) #16
Message was sent while issue was closed. 
https://codereview.chromium.org/715653004/diff/80001/Source/web/WebDocument.cpp
File Source/web/WebDocument.cpp (right):

https://codereview.chromium.org/715653004/diff/80001/Source/web/WebDocument.c...
Source/web/WebDocument.cpp:308: document->hideTransitionElements(cssSelector);
As a note, this is fixed in https://codereview.chromium.org/723073003/

Powered by Google App Engine
This is Rietveld 408576698