Issue 715633005: Rename HTMLInputElement::imageLoader() to ensureImageLoader()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 715633005: Rename HTMLInputElement::imageLoader() to ensureImageLoader() (Closed)

Created:
6 years, 1 month ago by rwlbuis

Modified:
6 years, 1 month ago

Reviewers:
adamk

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Rename HTMLInputElement::imageLoader() to ensureImageLoader() Make clear that imageLoader is potentially constructing the ImageLoader by renaming to ensureImageLoader. Also rename hasImageLoader to imageLoader and make it return a pointer, so it can be used both to check if the ImageLoader is created as well as use it if not null. http://trac.webkit.org/changeset/175764 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185143

Patch Set 1 #

Patch Set 2 : Fix crash #

Patch Set 3 : Add missing part #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -21 lines)			Patch
M	Source/core/html/HTMLInputElement.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLInputElement.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/html/forms/ImageInputType.cpp	View	1 2	3 chunks	+11 lines, -15 lines	0 comments	Download
M	Source/core/page/PageSerializer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715633005/40001

6 years, 1 month ago (2014-11-11 19:54:10 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-11 20:38:00 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as 185143

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages