Issue 715633004: Use the experimental PBQP register allocator for UBSan builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 715633004: Use the experimental PBQP register allocator for UBSan builds. (Closed)

Created:
6 years, 1 month ago by Alexander Potapenko

Modified:
6 years, 1 month ago

Reviewers:
inferno

CC:
chromium-reviews, kcc2, samsonov1

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Use the experimental PBQP register allocator for UBSan builds. This decreases compile time, so we don't need to build certain libraries with -O0 anymore (and we can't because PBQP doesn't support -O0) BUG=426271 TBR=inferno@chromium.org Committed: https://crrev.com/dfb61d8d703376828a3c53cf4c388931dd6b45f3 Cr-Commit-Position: refs/heads/master@{#303657}

Patch Set 1 #

Patch Set 2 : Add -O2 back for libgl. #

Patch Set 3 : Don't compile libmesa -O0 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -16 lines)			Patch
M	build/common.gypi	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	third_party/mesa/mesa.gyp	View	1 2	1 chunk	+0 lines, -8 lines	0 comments	Download
M	ui/gl/gl.gyp	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715633004/40001

6 years, 1 month ago (2014-11-11 15:30:41 UTC) #3

commit-bot: I haz the power

Patchset 3 (id:??) landed as https://crrev.com/dfb61d8d703376828a3c53cf4c388931dd6b45f3 Cr-Commit-Position: refs/heads/master@{#303657}

6 years, 1 month ago (2014-11-11 16:29:19 UTC) #5

inferno

6 years, 1 month ago (2014-11-11 19:16:01 UTC) #6

Message was sent while issue was closed.

lgtm.

i am OOO for a month, please feel free to ping mbarbella@ for any reviews.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages