Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 715633003: Fix reporting_level_ initialization (Closed)

Created:
6 years, 1 month ago by Steven Holte
Modified:
6 years, 1 month ago
CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix reporting_level_ initialization BUG=431833 Committed: https://crrev.com/b35d1e1ad264ee432442cfe7d988880a44ca07d7 Cr-Commit-Position: refs/heads/master@{#303518}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M components/rappor/rappor_service.cc View 1 2 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Will Harris
lgtm modulo either more description in the CL about the issue, or a BUG= reference.
6 years, 1 month ago (2014-11-10 19:49:58 UTC) #2
Alexei Svitkine (slow)
lgtm, but yeah please make a crbug - especially if you intend to merge this ...
6 years, 1 month ago (2014-11-10 19:51:21 UTC) #4
Will Harris
On 2014/11/10 19:51:21, Alexei Svitkine wrote: > lgtm, but yeah please make a crbug - ...
6 years, 1 month ago (2014-11-10 19:52:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715633003/40001
6 years, 1 month ago (2014-11-10 20:45:37 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/20769)
6 years, 1 month ago (2014-11-10 21:25:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715633003/40001
6 years, 1 month ago (2014-11-10 21:32:42 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-10 22:08:11 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 22:09:15 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b35d1e1ad264ee432442cfe7d988880a44ca07d7
Cr-Commit-Position: refs/heads/master@{#303518}

Powered by Google App Engine
This is Rietveld 408576698