Source/modules/mediastream/MediaConstraintsImpl.cpp - Issue 715583008: Remove Dictionary::getOwnPropertyNames()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/mediastream/MediaConstraintsImpl.cpp

Issue 715583008: Remove Dictionary::getOwnPropertyNames() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/mediastream/MediaConstraintsImpl.cpp

diff --git a/Source/modules/mediastream/MediaConstraintsImpl.cpp b/Source/modules/mediastream/MediaConstraintsImpl.cpp

index cc9f7f5eb3a7baf2a48ff75059da4edf4f48c7c0..66d3a5dbfc49e32ed0e39ee4766b01adefe4abfb 100644

--- a/Source/modules/mediastream/MediaConstraintsImpl.cpp

+++ b/Source/modules/mediastream/MediaConstraintsImpl.cpp

@@ -50,7 +50,7 @@ static bool parse(const Dictionary& constraintsDictionary, WebVector<WebMediaCon

return true;

Vector<String> names;

- constraintsDictionary.getOwnPropertyNames(names);

+ constraintsDictionary.getPropertyNames(names);

String mandatoryName("mandatory");

String optionalName("optional");

@@ -95,7 +95,7 @@ static bool parse(const Dictionary& constraintsDictionary, WebVector<WebMediaCon

if (!ok || constraint.isUndefinedOrNull())

return false;

Vector<String> localNames;

- constraint.getOwnPropertyNames(localNames);

+ constraint.getPropertyNames(localNames);

if (localNames.size() != 1)

return false;

String key = localNames[0];