Add mirrored screen option

Add mirrored screen option.
 This option flips scree image horizontally.

BUG=431731
R=mukai@chromium.org

Committed: https://crrev.com/04a9958219dd71e823dc04819abe75b5f9eb7e38
Cr-Commit-Position: refs/heads/master@{#304160}

[oshima, 2014-11-13 13:57:22]

Patchset #1 (id:1) has been deleted

[oshima, 2014-11-13 13:57:31]

Patchset #1 (id:1) has been deleted

[oshima, 2014-11-13 14:00:35]

oshima@chromium.org changed reviewers:
+ isherman@chromium.org

[oshima, 2014-11-13 14:00:36]

mukai -> ping
isherman -> tool/metrics/histograms

[Jun Mukai, 2014-11-13 17:33:31]

lgtm

https://codereview.chromium.org/715543004/diff/40001/ash/ash_switches.h
File ash/ash_switches.h (right):

https://codereview.chromium.org/715543004/diff/40001/ash/ash_switches.h#newco...
ash/ash_switches.h:29: ASH_EXPORT extern const char
kAshDisableTextFilteringInOverviewMode[];
nit: "TextFiltering" should appear before "TouchExploration" if it's
alphabetical ordering.

https://codereview.chromium.org/715543004/diff/40001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/715543004/diff/40001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:48023: +  <int value="1416592483"
label="ash-enable-mirrored-screen"/>
Just to confirm: is it automatically set by about_flags?  Can't see where it's
used.

[Jun Mukai, 2014-11-13 17:36:59]

https://codereview.chromium.org/715543004/diff/40001/ash/display/root_window_...
File ash/display/root_window_transformers.cc (right):

https://codereview.chromium.org/715543004/diff/40001/ash/display/root_window_...
ash/display/root_window_transformers.cc:127: gfx::Transform
CreateMirrorTransform(const gfx::Display& display) {
one more nit: could you write a comment for this function?
People like me will get confused this by screen mirroring.

[oshima, 2014-11-13 20:30:34]

https://codereview.chromium.org/715543004/diff/40001/ash/ash_switches.h
File ash/ash_switches.h (right):

https://codereview.chromium.org/715543004/diff/40001/ash/ash_switches.h#newco...
ash/ash_switches.h:29: ASH_EXPORT extern const char
kAshDisableTextFilteringInOverviewMode[];
On 2014/11/13 17:33:31, Jun Mukai wrote:
> nit: "TextFiltering" should appear before "TouchExploration" if it's
> alphabetical ordering.

Done.

https://codereview.chromium.org/715543004/diff/40001/ash/display/root_window_...
File ash/display/root_window_transformers.cc (right):

https://codereview.chromium.org/715543004/diff/40001/ash/display/root_window_...
ash/display/root_window_transformers.cc:127: gfx::Transform
CreateMirrorTransform(const gfx::Display& display) {
On 2014/11/13 17:36:59, Jun Mukai wrote:
> one more nit: could you write a comment for this function?
> People like me will get confused this by screen mirroring.

Added comment where the transform is applied.

https://codereview.chromium.org/715543004/diff/40001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/715543004/diff/40001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:48023: +  <int value="1416592483"
label="ash-enable-mirrored-screen"/>
On 2014/11/13 17:33:31, Jun Mukai wrote:
> Just to confirm: is it automatically set by about_flags?  Can't see where it's
> used.

This is necessary for AboutFlagsHistogramTest.

[Ilya Sherman, 2014-11-13 22:37:42]

histograms.xml lgtm, thanks.

[oshima, 2014-11-13 22:39:52]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-11-13 22:41:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/715543004/60001

[commit-bot: I haz the power, 2014-11-13 22:54:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-13 22:54:02]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2014-11-13 23:31:18]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-11-13 23:32:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/715543004/80001

[commit-bot: I haz the power, 2014-11-13 23:43:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-13 23:43:32]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[oshima, 2014-11-14 01:42:25]

Patchset #4 (id:80001) has been deleted

[oshima, 2014-11-14 01:42:49]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-11-14 01:45:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/715543004/100001

[commit-bot: I haz the power, 2014-11-14 04:04:55]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2014-11-14 04:05:34]

Patchset 4 (id:??) landed as
https://crrev.com/04a9958219dd71e823dc04819abe75b5f9eb7e38
Cr-Commit-Position: refs/heads/master@{#304160}

[oshima, 2014-11-14 18:54:39]

Patchset #5 (id:120001) has been deleted