Issue 7155025: Fix string-enums in ADMX templates

Issue 7155025: Fix string-enums in ADMX templates (Closed)

Created:
9 years, 6 months ago by gfeher

Modified:
9 years, 6 months ago

Reviewers:
markusheintz_

CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Fix string-enums in ADMX templates BUG=86141 TEST=verify that the value of ProxyMode set via the ADMX template is correctly reflected in about:net-internals Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89473

Patch Set 1 : " #

Total comments: 2

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -57 lines)			Patch
M	tools/grit/grit/format/policy_templates/writers/admx_writer.py	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/admx_writer_unittest.py	View	1 chunk	+31 lines, -23 lines	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/plist_writer.py	View	1 chunk	+1 line, -26 lines	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/xml_formatted_writer.py	View	2 chunks	+35 lines, -1 line	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/xml_writer_base_unittest.py	View	2 chunks	+2 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

markusheintz_

LGTM http://codereview.chromium.org/7155025/diff/3010/tools/grit/grit/format/policy_templates/writers/xml_writer_base_unittest.py File tools/grit/grit/format/policy_templates/writers/xml_writer_base_unittest.py (right): http://codereview.chromium.org/7155025/diff/3010/tools/grit/grit/format/policy_templates/writers/xml_writer_base_unittest.py#newcode30 tools/grit/grit/format/policy_templates/writers/xml_writer_base_unittest.py:30: child.toprettyxml(indent=' ') for child in parent.childNodes) Should this ...

9 years, 6 months ago (2011-06-16 14:39:54 UTC) #2

gfeher

9 years, 6 months ago (2011-06-17 08:53:57 UTC) #3

http://codereview.chromium.org/7155025/diff/3010/tools/grit/grit/format/polic...
File tools/grit/grit/format/policy_templates/writers/xml_writer_base_unittest.py
(right):

http://codereview.chromium.org/7155025/diff/3010/tools/grit/grit/format/polic...
tools/grit/grit/format/policy_templates/writers/xml_writer_base_unittest.py:30:
child.toprettyxml(indent='  ') for child in parent.childNodes)
All the tests should be refactored if I would switch here to ToPrettyXml. It may
make things overall nicer (I am not sure), but we don't need it since it is only
testStringEnums that requires strict checking of spaces. And in that test I am
already using ToPrettyXml.

Expand Messages | Collapse Messages