Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 715413003: Layout test for validating GLinfo on webglcontextcreationerror. (Closed)

Created:
6 years, 1 month ago by sivag
Modified:
5 years, 11 months ago
CC:
blink-reviews, Zhenyao Mo, bajones
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Layout test for validating GLinfo on Webglcontextcreationerror. This test uses the forceNextWebGLContextCreationToFail(bool) to fail the webgl context forcefully from JS-test runner utility and validates the status message for GLinfo generated by webglcontextcreationerror event. BUG=412440 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187766

Patch Set 1 #

Total comments: 6

Patch Set 2 : Refactoring layout test. #

Patch Set 3 : Fix for include issue in tests. #

Patch Set 4 : Handle gpu info collection failure. #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 1

Patch Set 7 : #

Total comments: 2

Patch Set 8 : #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -7 lines) Patch
A LayoutTests/fast/canvas/webgl/webgl-error-response.html View 1 2 3 4 1 chunk +42 lines, -0 lines 0 comments Download
A LayoutTests/fast/canvas/webgl/webgl-error-response-expected.txt View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 1 2 3 4 5 6 7 8 1 chunk +26 lines, -7 lines 0 comments Download
M public/platform/WebGraphicsContext3D.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 43 (12 generated)
sivag
ptal..
6 years, 1 month ago (2014-11-12 19:01:54 UTC) #2
Ken Russell (switch to Gerrit)
LGTM overall. Couple of minor comments. https://codereview.chromium.org/715413003/diff/1/LayoutTests/compositing/webgl/webgl-error-response.html File LayoutTests/compositing/webgl/webgl-error-response.html (right): https://codereview.chromium.org/715413003/diff/1/LayoutTests/compositing/webgl/webgl-error-response.html#newcode2 LayoutTests/compositing/webgl/webgl-error-response.html:2: WebGL context creation ...
6 years, 1 month ago (2014-11-12 22:13:23 UTC) #3
sivag
https://codereview.chromium.org/715413003/diff/1/LayoutTests/compositing/webgl/webgl-error-response.html File LayoutTests/compositing/webgl/webgl-error-response.html (right): https://codereview.chromium.org/715413003/diff/1/LayoutTests/compositing/webgl/webgl-error-response.html#newcode2 LayoutTests/compositing/webgl/webgl-error-response.html:2: WebGL context creation error message. --> On 2014/11/12 22:13:22, ...
6 years, 1 month ago (2014-11-14 12:20:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715413003/40001
6 years, 1 month ago (2014-11-14 12:22:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/36538)
6 years, 1 month ago (2014-11-14 14:07:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715413003/40001
6 years, 1 month ago (2014-11-14 16:46:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715413003/40001
6 years, 1 month ago (2014-11-14 19:01:22 UTC) #13
Ken Russell (switch to Gerrit)
Looks great. Thanks for adding this test.
6 years, 1 month ago (2014-11-14 19:04:44 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/30979)
6 years, 1 month ago (2014-11-14 23:52:59 UTC) #16
Ken Russell (switch to Gerrit)
On 2014/11/14 23:52:59, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 1 month ago (2014-11-15 00:01:03 UTC) #17
sivag
On 2014/11/15 00:01:03, Ken Russell wrote: > On 2014/11/14 23:52:59, I haz the power (commit-bot) ...
6 years, 1 month ago (2014-11-18 11:56:45 UTC) #18
Ken Russell (switch to Gerrit)
On 2014/11/18 11:56:45, Sikugu wrote: > On 2014/11/15 00:01:03, Ken Russell wrote: > > On ...
6 years, 1 month ago (2014-11-18 22:23:19 UTC) #19
sivag
On 2014/11/18 22:23:19, Ken Russell wrote: > On 2014/11/18 11:56:45, Sikugu wrote: > > On ...
6 years, 1 month ago (2014-11-19 12:59:20 UTC) #20
sivag
On 2014/11/19 12:59:20, Sikugu wrote: > On 2014/11/18 22:23:19, Ken Russell wrote: > > On ...
6 years ago (2014-12-10 09:49:37 UTC) #21
sivag
On 2014/11/18 22:23:19, Ken Russell wrote: > On 2014/11/18 11:56:45, Sikugu wrote: > > On ...
6 years ago (2014-12-10 14:19:35 UTC) #22
Ken Russell (switch to Gerrit)
On 2014/12/10 14:19:35, Sikugu wrote: > On 2014/11/18 22:23:19, Ken Russell wrote: > > On ...
6 years ago (2014-12-11 01:25:47 UTC) #23
sivag
@kbr, ptal..
6 years ago (2014-12-22 11:04:16 UTC) #24
Ken Russell (switch to Gerrit)
The win8_chromium_dbg and mac_chromium_dbg patch application failures are strange. Please resubmit try jobs and see ...
6 years ago (2014-12-23 02:56:47 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715413003/120001
6 years ago (2014-12-23 06:52:40 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/22937)
6 years ago (2014-12-23 06:58:52 UTC) #29
sivag
@pdr, ptal @public/platform/WebGraphicsContext3D.h changes.
6 years ago (2014-12-23 07:04:44 UTC) #31
sivag
philipj, ptal @WebKit/public changes.
5 years, 12 months ago (2014-12-24 10:38:12 UTC) #33
philipj_slow
It looks like the Chromium-side CL is https://codereview.chromium.org/800483002/ This CL doesn't verify the message added ...
5 years, 12 months ago (2014-12-25 13:14:29 UTC) #34
sivag
On 2014/12/25 13:14:29, philipj wrote: > It looks like the Chromium-side CL is https://codereview.chromium.org/800483002/ > ...
5 years, 12 months ago (2014-12-26 14:25:53 UTC) #35
philipj_slow
On 2014/12/26 14:25:53, sikugu wrote: > Regarding test, LayoutTests/fast/canvas/webgl/webgl-error-response.html > already takes care of GPUInfoCollectioFailure ...
5 years, 12 months ago (2014-12-27 09:13:07 UTC) #36
philipj_slow
https://codereview.chromium.org/715413003/diff/120001/Source/core/html/canvas/WebGLRenderingContext.cpp File Source/core/html/canvas/WebGLRenderingContext.cpp (right): https://codereview.chromium.org/715413003/diff/120001/Source/core/html/canvas/WebGLRenderingContext.cpp#newcode92 Source/core/html/canvas/WebGLRenderingContext.cpp:92: statusMessage.append("Could not create a WebGL context."); Add a space ...
5 years, 12 months ago (2014-12-27 09:13:14 UTC) #37
sivag
On 2014/12/27 09:13:07, philipj wrote: > On 2014/12/26 14:25:53, sikugu wrote: > > Regarding test, ...
5 years, 11 months ago (2014-12-29 12:54:59 UTC) #38
sivag
https://codereview.chromium.org/715413003/diff/120001/Source/core/html/canvas/WebGLRenderingContext.cpp File Source/core/html/canvas/WebGLRenderingContext.cpp (right): https://codereview.chromium.org/715413003/diff/120001/Source/core/html/canvas/WebGLRenderingContext.cpp#newcode92 Source/core/html/canvas/WebGLRenderingContext.cpp:92: statusMessage.append("Could not create a WebGL context."); On 2014/12/27 09:13:14, ...
5 years, 11 months ago (2014-12-29 13:08:53 UTC) #39
philipj_slow
OK, since kbr@ was happy this LGTM.
5 years, 11 months ago (2014-12-29 19:37:22 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715413003/160001
5 years, 11 months ago (2014-12-30 03:20:37 UTC) #42
commit-bot: I haz the power
5 years, 11 months ago (2014-12-30 04:34:32 UTC) #43
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187766

Powered by Google App Engine
This is Rietveld 408576698