Remove FontPlatformData::m_widthVariant.

Remove FontPlatformData::m_widthVariant.

The width variant is actually just a font feature request.
Now that HarfBuzzShaper::setFontFeatures() takes care of setting these
font features based on the FontDescription, there is no longer a need
to plumb these values though FontPlatformData.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185391

[bungeman-chromium, 2014-11-12 23:31:02]

bungeman@chromium.org changed reviewers:
+ dominik.rottsches@intel.com, eae@chromium.org

[Dominik Röttsches, 2014-11-13 13:42:22]

Nice! Since there's no TestExpectations change and the bots are green, I assume
tests like font-variant-width.html and emphasis-combined-text.html are still
working, right?

LGTM, with a nit.

https://codereview.chromium.org/715363005/diff/20001/Source/platform/fonts/Fo...
File Source/platform/fonts/FontPlatformData.cpp (right):

https://codereview.chromium.org/715363005/diff/20001/Source/platform/fonts/Fo...
Source/platform/fonts/FontPlatformData.cpp:288: && m_style == a.m_style
I'd put semicolons here and...

https://codereview.chromium.org/715363005/diff/20001/Source/platform/fonts/Fo...
Source/platform/fonts/FontPlatformData.cpp:291: && m_isCompositeFontReference ==
a.m_isCompositeFontReference
here.

https://codereview.chromium.org/715363005/diff/20001/Source/platform/fonts/Fo...
Source/platform/fonts/FontPlatformData.cpp:293: && true;
instead of this tail end.

[bungeman-chromium, 2014-11-13 17:40:09]

On 2014/11/13 13:42:22, Dominik Röttsches wrote:
> Nice! Since there's no TestExpectations change and the bots are green, I
assume
> tests like font-variant-width.html and emphasis-combined-text.html are still
> working, right?
> 

From the mac_blink_dbg trybot:

13:47:39.933 30915 worker/3
virtual/antialiasedtext/fast/text/font-variant-width.html passed
14:00:25.008 30915 worker/3 virtual/textblob/fast/text/font-variant-width.html
passed
14:39:48.958 30914 worker/2 fast/text/font-variant-width.html passed

13:47:23.034 30915 worker/3
virtual/antialiasedtext/fast/text/emphasis-combined-text.html passed
14:00:08.650 30915 worker/3
virtual/textblob/fast/text/emphasis-combined-text.html passed
14:39:32.074 30914 worker/2 fast/text/emphasis-combined-text.html passed

The Mac FontPlatformData was the only one using this. I don't believe that
setting the feature attribute on the CTFont has any use anymore, since these
features are being set through HarfBuzzShaper::setFontFeatures() now. From the
trybots, this seems to be the case.

[bungeman-chromium, 2014-11-13 17:49:43]

https://codereview.chromium.org/715363005/diff/20001/Source/platform/fonts/Fo...
File Source/platform/fonts/FontPlatformData.cpp (right):

https://codereview.chromium.org/715363005/diff/20001/Source/platform/fonts/Fo...
Source/platform/fonts/FontPlatformData.cpp:288: && m_style == a.m_style
On 2014/11/13 13:42:22, Dominik Röttsches wrote:
> I'd put semicolons here and...

Done.

https://codereview.chromium.org/715363005/diff/20001/Source/platform/fonts/Fo...
Source/platform/fonts/FontPlatformData.cpp:291: && m_isCompositeFontReference ==
a.m_isCompositeFontReference
On 2014/11/13 13:42:22, Dominik Röttsches wrote:
> here.

Done.

https://codereview.chromium.org/715363005/diff/20001/Source/platform/fonts/Fo...
Source/platform/fonts/FontPlatformData.cpp:293: && true;
On 2014/11/13 13:42:22, Dominik Röttsches wrote:
> instead of this tail end.

Done.

[bungeman-chromium, 2014-11-13 17:50:27]

The CQ bit was checked by bungeman@chromium.org

[commit-bot: I haz the power, 2014-11-13 17:51:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/715363005/40001

[commit-bot: I haz the power, 2014-11-13 17:54:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-13 17:54:34]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[bungeman-chromium, 2014-11-13 18:30:26]

On 2014/11/13 17:54:34, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   blink_presubmit on tryserver.blink
>
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

eae, looks like we need you to take a look at this too. You seem to be an OWNER
of Source/core, and the changes there are pretty straight-forward consequences
of the changes to Source/platform/fonts.

[eae, 2014-11-14 20:38:17]

Very nice! LGTM

[eae, 2014-11-14 20:38:28]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2014-11-14 20:38:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/715363005/40001

[commit-bot: I haz the power, 2014-11-14 20:45:42]

Committed patchset #3 (id:40001) as 185391