Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 715353002: IDL: Support callback function types in overload resolution (Closed)

Created:
6 years, 1 month ago by Jens Widell
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Support callback function types in overload resolution The specification has a "if Callable(V) is true, ..." case for (among other things) callback function types, which is implemented here, only for callback function types. BUG=293561 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -2 lines) Patch
M Source/bindings/scripts/v8_interface.py View 1 chunk +23 lines, -2 lines 0 comments Download
M Source/bindings/tests/idls/core/TestObject.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 2 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL No CG changes, since no existing overloads depend on callback function typed arguments.
6 years, 1 month ago (2014-11-12 16:31:46 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-11-12 16:35:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715353002/1
6 years, 1 month ago (2014-11-12 16:38:10 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 18:37:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185230

Powered by Google App Engine
This is Rietveld 408576698