Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 715333003: Revert of Replace GrResourceCache with GrResourceCache2. (Closed)

Created:
6 years, 1 month ago by bsalomon
Modified:
6 years, 1 month ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Replace GrResourceCache with GrResourceCache2. (patchset #6 id:100001 of https://codereview.chromium.org/716143004/) Reason for revert: Breaking stuff Original issue's description: > Replace GrResourceCache with GrResourceCache2. > > BUG=skia:2889 > > Committed: https://skia.googlesource.com/skia/+/66a450f21a3da174b7eed89a1d5fc8591e8b6ee6 TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2889 Committed: https://skia.googlesource.com/skia/+/f21dab95405979a4aff9f6a741c818304a67f220

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1028 lines, -734 lines) Patch
M bench/GrResourceCacheBench.cpp View 5 chunks +22 lines, -16 lines 0 comments Download
M gyp/gpu.gyp View 1 chunk +10 lines, -0 lines 0 comments Download
M gyp/gpu.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M include/gpu/GrConfig.h View 1 chunk +18 lines, -0 lines 0 comments Download
M include/gpu/GrContext.h View 7 chunks +13 lines, -4 lines 0 comments Download
M include/gpu/GrGpuResource.h View 3 chunks +3 lines, -1 line 0 comments Download
M include/gpu/GrUserConfig.h View 1 chunk +12 lines, -0 lines 0 comments Download
M include/gpu/SkGr.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 32 chunks +103 lines, -50 lines 0 comments Download
M src/gpu/GrGpuResource.cpp View 6 chunks +14 lines, -19 lines 0 comments Download
M src/gpu/GrGpuResourceCacheAccess.h View 1 chunk +19 lines, -0 lines 0 comments Download
M src/gpu/GrPath.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrPathRange.h View 1 chunk +1 line, -0 lines 0 comments Download
A src/gpu/GrResourceCache.h View 1 chunk +251 lines, -0 lines 0 comments Download
A src/gpu/GrResourceCache.cpp View 1 chunk +393 lines, -0 lines 0 comments Download
M src/gpu/GrResourceCache2.h View 4 chunks +14 lines, -189 lines 0 comments Download
M src/gpu/GrResourceCache2.cpp View 7 chunks +3 lines, -297 lines 0 comments Download
M src/gpu/GrStencilBuffer.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrTexture.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 19 chunks +114 lines, -150 lines 0 comments Download
M tests/SurfaceTest.cpp View 2 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bsalomon
Created Revert of Replace GrResourceCache with GrResourceCache2.
6 years, 1 month ago (2014-11-13 21:31:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715333003/1
6 years, 1 month ago (2014-11-13 21:32:55 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 21:33:35 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f21dab95405979a4aff9f6a741c818304a67f220

Powered by Google App Engine
This is Rietveld 408576698