Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 715233003: IDL: Add Function and VoidFunction as built-in callback function types (Closed)

Created:
6 years, 1 month ago by Jens Widell
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Add Function and VoidFunction as built-in callback function types They are included as "common definitions" in WebIDL and can thus be used by other specifications without definition. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185216

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M Source/bindings/scripts/idl_types.py View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Jens Widell
PTAL Doesn't change anything currently, since neither type is used. The Function type is used ...
6 years, 1 month ago (2014-11-12 12:32:04 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-11-12 13:16:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715233003/1
6 years, 1 month ago (2014-11-12 13:17:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/36075)
6 years, 1 month ago (2014-11-12 15:34:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715233003/1
6 years, 1 month ago (2014-11-12 15:35:07 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 16:25:06 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185216

Powered by Google App Engine
This is Rietveld 408576698