Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 715223002: Make ThreadData::random_number_ an unsigned integer so that overflow has defined behavior. (Closed)

Created:
6 years, 1 month ago by Alexander Potapenko
Modified:
6 years, 1 month ago
CC:
chromium-reviews, erikwright+watch_chromium.org, rickyz (no longer on Chrome)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make ThreadData::random_number_ an unsigned integer so that overflow has defined behavior. The problem has been spotted by UBSan in base_unittests: [ RUN ] FileProxyTest.SetLength_Expand ../../base/tracked_objects.cc:457:18: runtime error: signed integer overflow: 1517486279 + 2147483647 cannot be represented in type 'int' [ OK ] FileProxyTest.SetLength_Expand (2 ms) R=jar@chromium.org TBR=darin@chromium.org BUG=none Committed: https://crrev.com/f7812575621806b0994ff4f96db61de3c0962fd1 Cr-Commit-Position: refs/heads/master@{#303893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M base/tracked_objects.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/tracked_objects.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Alexander Potapenko
Please take a look.
6 years, 1 month ago (2014-11-12 09:17:33 UTC) #1
jar (doing other things)
lgtm
6 years, 1 month ago (2014-11-12 17:06:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715223002/1
6 years, 1 month ago (2014-11-12 17:07:44 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/23715)
6 years, 1 month ago (2014-11-12 17:12:03 UTC) #6
Alexander Potapenko
On 2014/11/12 17:12:03, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 1 month ago (2014-11-12 21:01:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715223002/1
6 years, 1 month ago (2014-11-12 21:02:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-12 21:05:42 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 21:06:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7812575621806b0994ff4f96db61de3c0962fd1
Cr-Commit-Position: refs/heads/master@{#303893}

Powered by Google App Engine
This is Rietveld 408576698