tools/metrics/histograms/histograms.xml - Issue 715193002: [Password Generation] Breakout UMA stats for generated passwords

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 715193002: [Password Generation] Breakout UMA stats for generated passwords (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« components/password_manager/core/browser/login_database_unittest.cc ('K') | « components/password_manager/core/browser/login_database_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index eb5c2e2c5f6658f186936b9cae4e9cf7d9177fca..e31e9037de6100bc4657a95ef6305c1551fa8a22 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -22290,6 +22290,10 @@ Therefore, the affected-histogram name has to have at least one dot in it.

<owner>gcasto@chromium.org</owner>

<owner>vabr@chromium.org</owner>

+ <obsolete>

+ Deprecated as of 11/11/14. New statistic is

+ PasswordManager.TimesPasswordUsed.AutoGenerated.

+ </obsolete>

The number of times each generated password has been used to log in.

Recorded by iterating over stored passwords once per run. This information

@@ -56826,9 +56830,20 @@ To add a new entry, add it with any value and run test to compute valid value.

<histogram_suffixes name="PasswordCustomPassphrase" separator=".">

- <affected-histogram name="PasswordManager.AccountsPerSite"/>

Ilya Sherman 2014/11/13 01:54:53 nit: Please keep this, so that old data remains vi

Garrett Casto 2014/11/18 22:30:24 Done.

+ <affected-histogram name="PasswordManager.AccountsPerSite.AutoGenerated"/>

+ <affected-histogram name="PasswordManager.AccountsPerSite.UserCreated"/>

<affected-histogram name="PasswordManager.BlacklistedSites"/>

<affected-histogram name="PasswordManager.TimesGeneratedPasswordUsed"/>

+ <affected-histogram name="PasswordManager.TimesPasswordUsed.AutoGenerated"/>

+ <affected-histogram name="PasswordManager.TimesPasswordUsed.UserCreated"/>

+ <affected-histogram name="PasswordManager.TotalAccounts.AutoGenerated"/>

+ <affected-histogram name="PasswordManager.TotalAccounts.UserCreated"/>

+</histogram_suffixes>

+<histogram_suffixes name="PasswordGenerated" separator=".">

+ <suffix name="UserCreated"/>

+ <suffix name="AutoGenerated"/>

+ <affected-histogram name="PasswordManager.AccountsPerSite"/>

<affected-histogram name="PasswordManager.TimesPasswordUsed"/>

<affected-histogram name="PasswordManager.TotalAccounts"/>

</histogram_suffixes>