[Password Generation] Breakout UMA stats for generated passwords

[Password Generation] Breakout UMA stats for generated passwords

The main impetus of this change is to make it possible to calculate
the percentage of generated passwords overriden by non-generated passwords, for
which we need the total number of generated passwords

BUG=432407
Committed: https://crrev.com/8a2bc4a5300bdcd37221ab634a1e1143c1b02f79
Cr-Commit-Position: refs/heads/master@{#304716}

[Garrett Casto, 2014-11-12 05:55:24]

gcasto@chromium.org changed reviewers:
+ isherman@chromium.org

[Ilya Sherman, 2014-11-13 01:54:53]

https://codereview.chromium.org/715193002/diff/20001/components/password_mana...
File components/password_manager/core/browser/login_database.cc (right):

https://codereview.chromium.org/715193002/diff/20001/components/password_mana...
components/password_manager/core/browser/login_database.cc:326: int
total_accounts = 0;
Perhaps this should be renamed to something like "total_user_created_accounts"?

https://codereview.chromium.org/715193002/diff/20001/components/password_mana...
File components/password_manager/core/browser/login_database_unittest.cc
(right):

https://codereview.chromium.org/715193002/diff/20001/components/password_mana...
components/password_manager/core/browser/login_database_unittest.cc:973:
user_created.type = PasswordForm::TYPE_GENERATED;
It seems pretty weird to still be calling the account "user created" at this
point.

https://codereview.chromium.org/715193002/diff/20001/components/password_mana...
components/password_manager/core/browser/login_database_unittest.cc:1013:
histogram_tester.ExpectBucketCount(
nit: Perhaps call ExpectUniqueSample here?

https://codereview.chromium.org/715193002/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/715193002/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:56829: -  <affected-histogram
name="PasswordManager.AccountsPerSite"/>
nit: Please keep this, so that old data remains viewable.

[Garrett Casto, 2014-11-18 22:30:24]

https://codereview.chromium.org/715193002/diff/20001/components/password_mana...
File components/password_manager/core/browser/login_database.cc (right):

https://codereview.chromium.org/715193002/diff/20001/components/password_mana...
components/password_manager/core/browser/login_database.cc:326: int
total_accounts = 0;
On 2014/11/13 01:54:53, Ilya Sherman wrote:
> Perhaps this should be renamed to something like
"total_user_created_accounts"?

Done.

https://codereview.chromium.org/715193002/diff/20001/components/password_mana...
File components/password_manager/core/browser/login_database_unittest.cc
(right):

https://codereview.chromium.org/715193002/diff/20001/components/password_mana...
components/password_manager/core/browser/login_database_unittest.cc:973:
user_created.type = PasswordForm::TYPE_GENERATED;
On 2014/11/13 01:54:53, Ilya Sherman wrote:
> It seems pretty weird to still be calling the account "user created" at this
> point.

Changed.

https://codereview.chromium.org/715193002/diff/20001/components/password_mana...
components/password_manager/core/browser/login_database_unittest.cc:1013:
histogram_tester.ExpectBucketCount(
On 2014/11/13 01:54:53, Ilya Sherman wrote:
> nit: Perhaps call ExpectUniqueSample here?

Done.

https://codereview.chromium.org/715193002/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/715193002/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:56829: -  <affected-histogram
name="PasswordManager.AccountsPerSite"/>
On 2014/11/13 01:54:53, Ilya Sherman wrote:
> nit: Please keep this, so that old data remains viewable.

Done.

[Ilya Sherman, 2014-11-18 22:37:10]

LGTM, thanks.

https://codereview.chromium.org/715193002/diff/40001/components/password_mana...
File components/password_manager/core/browser/login_database.cc (right):

https://codereview.chromium.org/715193002/diff/40001/components/password_mana...
components/password_manager/core/browser/login_database.cc:356: total_accounts
+= accounts_per_site;
You might want to update the variable name here and below as well ;)

[Garrett Casto, 2014-11-18 22:54:49]

https://codereview.chromium.org/715193002/diff/40001/components/password_mana...
File components/password_manager/core/browser/login_database.cc (right):

https://codereview.chromium.org/715193002/diff/40001/components/password_mana...
components/password_manager/core/browser/login_database.cc:356: total_accounts
+= accounts_per_site;
On 2014/11/18 22:37:10, Ilya Sherman wrote:
> You might want to update the variable name here and below as well ;)

What I get for sending a response while compiling. Done.

[Garrett Casto, 2014-11-18 22:58:19]

The CQ bit was checked by gcasto@chromium.org

[commit-bot: I haz the power, 2014-11-18 23:00:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/715193002/60001

[commit-bot: I haz the power, 2014-11-19 00:29:46]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-11-19 00:30:29]

Patchset 4 (id:??) landed as
https://crrev.com/8a2bc4a5300bdcd37221ab634a1e1143c1b02f79
Cr-Commit-Position: refs/heads/master@{#304716}