Push uiautomator test jar to its own folder in tmp

Push uiautomator test jar to its own folder in tmp

When running uiautomator tests through test_runner the contents of
/data/local/tmp is hashed using md5sum_bin to see if a push is needed. This is
inefficient when tmp contains unrelated large files, and it relies on md5sum.cc
to be able to handle a wide range of filetypes including named pipes.

By transferring chrome_shell_uiautomator.dex.jar to /data/local/tmp/uiautomator
we hash fewer files, and can be confident that the files are only files we care
about (of type .jar or .dex.jar).

Tested on a Nexus:
./build/android/test_runner.py uiautomator -v -v
  --test-jar=chrome_shell_uiautomator_tests --package=chrome_shell

BUG=432341
Committed: https://crrev.com/cc91e2ffbdff758fb3f89f3521bb6f0539383c43
Cr-Commit-Position: refs/heads/master@{#303872}

[davileen, 2014-11-12 01:06:52]

davileen@amazon.com changed reviewers:
+ jbudorick@chromium.org

[davileen, 2014-11-12 01:06:52]

Hi jbudorick,

Here's a proposed fix for
https://code.google.com/p/chromium/issues/detail?id=432341

Please let me know what you think.

Thanks,
David.

[jbudorick, 2014-11-12 15:37:20]

Hi David,

This change lgtm as a fix for the immediate issue.

However, the long term fix probably involves changes to device_utils s.t.:
 - we don't md5sum everything in a directory, only the things we care about in a
given push, and
 - we don't md5sum particular file types, e.g. named pipes.

I'll file those separately and can cc you on them if you'd like.

Thanks for the patch!

John

[davileen, 2014-11-12 18:30:42]

The CQ bit was checked by davileen@amazon.com

[commit-bot: I haz the power, 2014-11-12 18:31:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/715153002/1

[davileen, 2014-11-12 19:26:46]

On 2014/11/12 15:37:20, jbudorick wrote:
> Hi David,
> 
> This change lgtm as a fix for the immediate issue.
> 
> However, the long term fix probably involves changes to device_utils s.t.:
>  - we don't md5sum everything in a directory, only the things we care about in
a
> given push, and
>  - we don't md5sum particular file types, e.g. named pipes.
> 
> I'll file those separately and can cc you on them if you'd like.
> 
> Thanks for the patch!
> 
> John

Hi John,

Thanks for the review!

I agree about the long term plan. While investigating this fix I came across a
suggestion to use rsync:
"have you looked into using rsync? It's probably not too hard to build for arm."
(mentioned in the 2nd post https://codereview.chromium.org/646523002/)

However I can't seem to view the issue that you created:
https://code.google.com/p/chromium/issues/detail?id=421938

Any thoughts?

David.

[commit-bot: I haz the power, 2014-11-12 19:33:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-12 19:33:57]

Patchset 1 (id:??) landed as
https://crrev.com/cc91e2ffbdff758fb3f89f3521bb6f0539383c43
Cr-Commit-Position: refs/heads/master@{#303872}