Issue 715073002: Early return from WebPluginContainerImpl::scriptableObject if the plugin gets destroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 715073002: Early return from WebPluginContainerImpl::scriptableObject if the plugin gets destroyed (Closed)

Created:
6 years, 1 month ago by raymes

Modified:
6 years, 1 month ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Early return from WebPluginContainerImpl::scriptableObject if the plugin gets destroyed WebPluginContainerImpl::scriptableObject calls into WebPlugin::scriptableObject which (in the PepperWebPluginImpl implementation) sends synchronous messages to the plugin which can result in re-entrancy. This re-entrancy may cause the plugin to be destroyed, which sets m_webPlugin to null in WebPluginContainerImpl::dispose. We need to check for a null value to avoid dereferencing a null pointer. BUG=423263 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185182