Issue 715053004: Make paddingBoxRect less dumb.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 715053004: Make paddingBoxRect less dumb. (Closed)

Created:
6 years, 1 month ago by ojan

Modified:
6 years, 1 month ago

Reviewers:
esprehn

CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Make paddingBoxRect less dumb. It was calling contentWidth, which did clientWidth - padding, and then adding the padding back in. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4454d68ee6f3362fc060ba67315734cc9cd89664

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	sky/engine/core/rendering/RenderBox.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (1 generated)

ojan

6 years, 1 month ago (2014-11-12 00:58:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4454d68ee6f3362fc060ba67315734cc9cd89664 (presubmit successful).