Introduce system_info as an independent container.

Introduce system_info as an independent container.

- system info persists on the screen, not in the background
- introduce a new container to overwrap with home card nicely
- conflicting with overview windows doesn't look correct -- therefore
  its y-coordinate should be moved by the height of system info.
- system_ui's "ColorScheme" isn't used anymore, since it's always
  white (LIGHT) colors in the latest mock. I'll create another CL
  to remove this.

BUG=425724
R=oshima@chromium.org
TEST=manually

Committed: https://crrev.com/74e4514d19ace4a49f533f9eeb48019f078bd869
Cr-Commit-Position: refs/heads/master@{#304043}

[oshima, 2014-11-12 20:35:03]

https://codereview.chromium.org/715053003/diff/20001/athena/home/home_card_vi...
File athena/home/home_card_view.cc (right):

https://codereview.chromium.org/715053003/diff/20001/athena/home/home_card_vi...
athena/home/home_card_view.cc:237: drag_indicator_bounds.Offset(0,
kSystemUIHeight);
This is ok for now, but we probably should update the work area and this code
should use the workare instead of const.

https://codereview.chromium.org/715053003/diff/20001/athena/system/system_ui_...
File athena/system/system_ui_impl.cc (right):

https://codereview.chromium.org/715053003/diff/20001/athena/system/system_ui_...
athena/system/system_ui_impl.cc:164: base::Bind(&ClearSystemInfo,
system_info_widget_)));
It's probably better to use ScopedHidingAnimatinoSettings, and pass the
container instead.

And what if the root window is deleted during the animation? Will this be
aborted?

[Jun Mukai, 2014-11-12 21:39:58]

https://codereview.chromium.org/715053003/diff/20001/athena/system/system_ui_...
File athena/system/system_ui_impl.cc (right):

https://codereview.chromium.org/715053003/diff/20001/athena/system/system_ui_...
athena/system/system_ui_impl.cc:164: base::Bind(&ClearSystemInfo,
system_info_widget_)));
On 2014/11/12 20:35:03, oshima wrote:
> It's probably better to use ScopedHidingAnimatinoSettings, and pass the
> container instead.
> 
> And what if the root window is deleted during the animation? Will this be
> aborted?

Removed the the code around here and replaced by ui/wm/core/window_animations
utilities.  PTAL.

[Jun Mukai, 2014-11-12 22:08:33]

also removed the ContainerDeleter

[oshima, 2014-11-12 22:38:10]

lgtm with a nit

https://codereview.chromium.org/715053003/diff/80001/athena/system/system_ui_...
File athena/system/system_ui_impl.cc (right):

https://codereview.chromium.org/715053003/diff/80001/athena/system/system_ui_...
athena/system/system_ui_impl.cc:29: #include "ui/wm/core/window_animations.h"
nit: can you cleanup includes?

[Jun Mukai, 2014-11-13 01:15:50]

https://codereview.chromium.org/715053003/diff/80001/athena/system/system_ui_...
File athena/system/system_ui_impl.cc (right):

https://codereview.chromium.org/715053003/diff/80001/athena/system/system_ui_...
athena/system/system_ui_impl.cc:29: #include "ui/wm/core/window_animations.h"
On 2014/11/12 22:38:10, oshima wrote:
> nit: can you cleanup includes?

Done.

[Jun Mukai, 2014-11-13 01:16:01]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-11-13 01:17:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/715053003/100001

[commit-bot: I haz the power, 2014-11-13 01:53:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-13 01:53:32]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Jun Mukai, 2014-11-13 17:28:30]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-11-13 17:29:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/715053003/100001

[commit-bot: I haz the power, 2014-11-13 17:50:03]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-11-13 17:50:42]

Patchset 6 (id:??) landed as
https://crrev.com/74e4514d19ace4a49f533f9eeb48019f078bd869
Cr-Commit-Position: refs/heads/master@{#304043}