Issue 715023002: Make SVGTextPositioningElement::elementFromRenderer take a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 715023002: Make SVGTextPositioningElement::elementFromRenderer take a reference (Closed)

Created:
6 years, 1 month ago by rwlbuis

Modified:
6 years, 1 month ago

Reviewers:
pdr.

CC:
blink-reviews, blink-reviews-rendering, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, zoltan1

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Make SVGTextPositioningElement::elementFromRenderer take a reference This avoids doing a null check in this method, adjust all call sites. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185160

Patch Set 1 #

Patch Set 2 : Fix compile problem #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -25 lines)			Patch
M	Source/core/rendering/svg/RenderSVGText.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/svg/SVGTextLayoutAttributesBuilder.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/rendering/svg/SVGTextLayoutAttributesBuilder.cpp	View	1	6 chunks	+12 lines, -12 lines	0 comments	Download
M	Source/core/svg/SVGTextPositioningElement.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGTextPositioningElement.cpp	View		1 chunk	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/715023002/20001

6 years, 1 month ago (2014-11-11 23:51:09 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-12 00:57:38 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 185160

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages