Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1373)

Unified Diff: Source/modules/serviceworkers/InstallEvent.h

Issue 715013003: ExtendableEvent and InstallEvent should have an EventConstructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: basic layout test Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/serviceworkers/ExtendableEvent.idl ('k') | Source/modules/serviceworkers/InstallEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/serviceworkers/InstallEvent.h
diff --git a/Source/modules/serviceworkers/InstallEvent.h b/Source/modules/serviceworkers/InstallEvent.h
index 79eabcaf329fa3ed5bad30350ddf43278490b7b6..97a97877623b47eaf37ad7b1ed61dd8308f80a5b 100644
--- a/Source/modules/serviceworkers/InstallEvent.h
+++ b/Source/modules/serviceworkers/InstallEvent.h
@@ -37,11 +37,14 @@
namespace blink {
+using InstallEventInit = ExtendableEventInit;
+
class InstallEvent final : public ExtendableEvent {
DEFINE_WRAPPERTYPEINFO();
public:
static PassRefPtrWillBeRawPtr<InstallEvent> create();
- static PassRefPtrWillBeRawPtr<InstallEvent> create(const AtomicString& type, const EventInit&, WaitUntilObserver*);
+ static PassRefPtrWillBeRawPtr<InstallEvent> create(const AtomicString& type, const InstallEventInit&);
+ static PassRefPtrWillBeRawPtr<InstallEvent> create(const AtomicString& type, const InstallEventInit&, WaitUntilObserver*);
virtual const AtomicString& interfaceName() const override;
@@ -49,7 +52,8 @@ public:
private:
InstallEvent();
- InstallEvent(const AtomicString& type, const EventInit&, WaitUntilObserver*);
+ InstallEvent(const AtomicString& type, const InstallEventInit&);
+ InstallEvent(const AtomicString& type, const InstallEventInit&, WaitUntilObserver*);
};
} // namespace blink
« no previous file with comments | « Source/modules/serviceworkers/ExtendableEvent.idl ('k') | Source/modules/serviceworkers/InstallEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698