Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 714883003: Reland "Avoid some unnecessary fast-properties map creations." (Closed)

Created:
6 years, 1 month ago by Jakob Kummerow
Modified:
6 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Reland "Avoid some unnecessary fast-properties map creations." This relands commit ea74f0f85a7730879a2f17721629f93525886092. The revert was due to failures in cctest/test-heap/ReleaseOverReservedPages, caused by apparent changes to memory layout and fragmentation of the first page. Eliminating a situation in messages.js where this CL has had an effect on map transitions seems to solve the issue. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25266

Patch Set 1 : original patch #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/messages.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/object-freeze.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-137689.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jakob Kummerow
PTAL. cctests pass on Linux in ia32.{release,optdebug,debug}.
6 years, 1 month ago (2014-11-11 15:20:19 UTC) #2
Toon Verwaest
lgtm
6 years, 1 month ago (2014-11-11 15:22:56 UTC) #3
Jakob Kummerow
6 years, 1 month ago (2014-11-11 15:41:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 25266 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698